[issue23001] Accept mutable bytes-like objects

STINNER Victor added the comment: > Thanks Victor. You're welcome, I just worked recently on ossaudiodev for _Py_read/write functions functions. But I'm not able to run ossaudiodev neither :-( I hope that the test runs on some buildbots (FreeBSD?). -- nosy: +haypo ___

[issue23001] Accept mutable bytes-like objects

Serhiy Storchaka added the comment: Thanks Victor. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue23001] Accept mutable bytes-like objects

Roundup Robot added the comment: New changeset d478a2a5738a by Victor Stinner in branch 'default': Issue #23709, #23001: ossaudiodev now uses Py_ssize_t for sizes instead of int https://hg.python.org/cpython/rev/d478a2a5738a -- ___ Python tracker

[issue23001] Accept mutable bytes-like objects

Roundup Robot added the comment: New changeset 11548e1ac920 by Victor Stinner in branch 'default': Issue #23001: Fix typo https://hg.python.org/cpython/rev/11548e1ac920 -- ___ Python tracker ___

[issue23001] Accept mutable bytes-like objects

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue23001] Accept mutable bytes-like objects

Roundup Robot added the comment: New changeset 17c77938c4e2 by Serhiy Storchaka in branch 'default': Issue #23001: Few functions in modules mmap, ossaudiodev, socket, ssl, and https://hg.python.org/cpython/rev/17c77938c4e2 -- nosy: +python-dev ___ Pyt

[issue23001] Accept mutable bytes-like objects

Serhiy Storchaka added the comment: Thank you for your review Martin. Yes, the problem with fcntl() is not so easy and I'll left it for the separate issue. > I noticed there is no test for “ossaudiodev”. Would that be too hard, or is > it just an oversight? It is hard because test_ossaudiodev

[issue23001] Accept mutable bytes-like objects

Martin Panter added the comment: I had a closer look at the changes, and most of them seem good. However I think I found one leak in fcntl(); see Reitveld. I noticed there is no test for “ossaudiodev”. Would that be too hard, or is it just an oversight? -- ___

[issue23001] Accept mutable bytes-like objects

Serhiy Storchaka added the comment: Added versionchanged directives and fixed other documentation. -- Added file: http://bugs.python.org/file38555/accept_mutable_buffers_2.patch ___ Python tracker _

[issue23001] Accept mutable bytes-like objects

Martin Panter added the comment: If this goes ahead, it would be nice adding notes to the documentation saying that bytearray() or whatever was previously not supported. There are APIs in Python 2.6 that had similar treatment with no documentation updates, and I keep being bitten by it. -

[issue23001] Accept mutable bytes-like objects

Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23001] Accept mutable bytes-like objects

Changes by Serhiy Storchaka : -- keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue23001] Accept mutable bytes-like objects

Antoine Pitrou added the comment: +1 on the principle. I haven't looked at the patch. -- nosy: +pitrou ___ Python tracker ___ ___ Pyth

[issue23001] Accept mutable bytes-like objects

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue23001] Accept mutable bytes-like objects

Josh Rosenberg added the comment: Ah, sorry. Should have examined patch. I thought you were making a change to the behavior of s#, z#, y and y#, not converting actual uses of them. Again, sorry. -- ___ Python tracker

[issue23001] Accept mutable bytes-like objects

Serhiy Storchaka added the comment: That is was the patch does. Convert from s# to s* etc. See also issue22896 about potential bugs with the use of pointers to unlocked buffers. -- ___ Python tracker

[issue23001] Accept mutable bytes-like objects

Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23001] Accept mutable bytes-like objects

Josh Rosenberg added the comment: In the event of calls back into Python code in multithreaded execution (or GIL release), this would mean you no longer have guarantees as to the contents (or even the validity) of the pointer you get back. I'd think the only safe way to accept mutable buffers

[issue23001] Accept mutable bytes-like objects

New submission from Serhiy Storchaka: Some builtins accept only read-only bytes-like objects (PyArg_Parse format codes "s#", "z#", "y", and "y#"). Proposed patch makes them accepting also mutable bytes-like objects such as bytearray. I'm not sure that all these changes are useful, but in some