[issue23018] Add version info to python

Roundup Robot added the comment: New changeset 843a8ee94270 by Steve Dower in branch 'default': Closes #23018: Replace copyright symbol with escape. https://hg.python.org/cpython/rev/843a8ee94270 -- resolution: -> fixed stage: -> resolved status: open -> closed ___

[issue23018] Add version info to python

Steve Dower added the comment: Digging around the likely encodings to be running on Windows machines, it looks like 0xA9 is always the right symbol, so that change should be fine. -- ___ Python tracker ___

[issue23018] Add version info to python

Serhiy Storchaka added the comment: I afraid that adding source file that can't be easy handled by Unix text tools (such as diff) is not good idea. Does "\xa9" work? -- ___ Python tracker _

[issue23018] Add version info to python

Steve Dower added the comment: Looks like the .rc files should actually be UCS-2, since that's how the strings are going to be stored into the executables. If I rename the .h file to .h_ (and change the encoding to UCS-2 with BOM), will it be ignored by argument clinic? -- __

[issue23018] Add version info to python

Serhiy Storchaka added the comment: PC/python_ver_rc.h now is not compatible with clinic.py. $ ./python Tools/clinic/clinic.py --make Traceback (most recent call last): File "Tools/clinic/clinic.py", line 4204, in sys.exit(main(sys.argv[1:])) File "Tools/clinic/clinic.py", line 4184, in

[issue23018] Add version info to python

Changes by Steve Dower : -- resolution: -> fixed stage: -> patch review status: open -> closed ___ Python tracker ___ ___ Python-bug

[issue23018] Add version info to python

Roundup Robot added the comment: New changeset 3f7e483cebef by Steve Dower in branch 'default': Issue 23018: Add version info to python[w].exe https://hg.python.org/cpython/rev/3f7e483cebef -- nosy: +python-dev ___ Python tracker

[issue23018] Add version info to python

Tim Golden added the comment: +1 from me, then. -- title: Add version info to python[w].exe -> Add version info to python ___ Python tracker ___ _

[issue23018] Add version info to python[w].exe

Steve Dower added the comment: Sure :) If you view Properties in Windows for Python 3.4's python[w].exe and look at the Details tab, it's very blank (for me it shows 'Application', the size and the modification date). However, if you look at python34.dll or py.exe it has a description, versio

[issue23018] Add version info to python[w].exe

Tim Golden added the comment: Steve, could you outline the need / impact for this, please? (ie can you inform my ignorance?). -- ___ Python tracker ___ _

[issue23018] Add version info to python[w].exe

Steve Dower added the comment: Anyone have any opinions on this? My only hesitation is adding the Windows 10 UUID, which will fix GetVersion but may cause other API problems, and we're certainly not testing against Windows 10 yet. (On the other hand, it's easy enough to remove that single UUID

[issue23018] Add version info to python[w].exe

Steve Dower added the comment: Add for Windows 10 (source: http://blogs.msdn.com/b/chuckw/archive/2013/09/10/manifest-madness.aspx) -- ___ Python tracker ___ _

[issue23018] Add version info to python[w].exe

Steve Dower added the comment: Patch for the version info, and also for half of #19143 since I was there. -- components: +Windows keywords: +patch nosy: +tim.golden, zach.ware Added file: http://bugs.python.org/file37393/23018.patch ___ Python tracker

[issue23018] Add version info to python[w].exe

New submission from Steve Dower: We should include the version resource in python[w].exe as well as python35.dll so that it can be properly identified. (If possible, we should do .pyd files too, though I don't think the version info will be displayed, so it's probably not worth it.) -