[issue2302] Uses of SocketServer.BaseServer.shutdown have a race

Antoine Pitrou added the comment: Fixed with a test in r80484 (trunk), r80486 (2.6), r80487 (py3k), r80491 (3.1). -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue2302] Uses of SocketServer.BaseServer.shutdown have a race

Antoine Pitrou added the comment: By the way, getting rid of poll_interval for a file descriptor is easy under Unix, but wouldn't work under Windows (where select() only takes sockets, not arbitrary file descriptors). -- ___ Python tracker

[issue2302] Uses of SocketServer.BaseServer.shutdown have a race

Antoine Pitrou added the comment: Here is a simpler patch. It also fixes the wrong use of a lock instead of an event in test_httpservers. With this patch, test_httpservers runs forever without freezing. -- Added file: http://bugs.python.org/file16964/shutdown.patch __

[issue2302] Uses of SocketServer.BaseServer.shutdown have a race

Antoine Pitrou added the comment: After a bit of investigation, this issue seems to be exactly why test_httpservers sometimes hangs. The patch looks complicated to me, though; I don't think we really have to support the multiple shutdowns case. -- nosy: +pitrou priority: -> normal ve

[issue2302] Uses of SocketServer.BaseServer.shutdown have a race

Changes by Giampaolo Rodola' <[EMAIL PROTECTED]>: -- nosy: +giampaolo.rodola ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-

[issue2302] Uses of SocketServer.BaseServer.shutdown have a race

Rafael Zanella <[EMAIL PROTECTED]> added the comment: >With the code as it stands, calls to shutdown that happen before >serve_forever enters its loop will deadlock, and there's no simple way >for the user to avoid this. The attached patch prevents the deadlock and >allows multiple serve_forever.

[issue2302] Uses of SocketServer.BaseServer.shutdown have a race

Changes by Jeffrey Yasskin <[EMAIL PROTECTED]>: -- assignee: -> jyasskin __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list U

[issue2302] Uses of SocketServer.BaseServer.shutdown have a race

New submission from Jeffrey Yasskin <[EMAIL PROTECTED]>: With the code as it stands, calls to shutdown that happen before serve_forever enters its loop will deadlock, and there's no simple way for the user to avoid this. The attached patch prevents the deadlock and allows multiple serve_forever..