[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Raymond Hettinger added the comment: I concur that this should be closed. -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker ___

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Terry J. Reedy added the comment: At least some idlelib imports are delayed to avoid circular import errors, as described by Nick. The patch adds 'Module level' before 'imports'. Pro: techinically correct as only module level imports can be put at the top. Com: might be seen as giving too

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Joannah Nanjekye added the comment: Since this is a PEP related issue, it should be moved to the PEP Github repository here : https://github.com/python/peps . If it still exists. -- nosy: +nanjekyejoannah ___ Python tracker

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Ian Lee added the comment: Are there any other concerns with the patch that I would be able to clean up? -- nosy: +barry ___ Python tracker ___

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Changes by Pas : -- nosy: +pas ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Raymond Hettinger added the comment: I would argue this is a good time to clean up that code in the standard library. Please leave any clean-ups to the module maintainers. PEP 8 is something you should do to your own code, rather than something you inflict on other people's code. We

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Ian Lee added the comment: So one concern that was brought up on GitHub was the fact that currently this is not actually followed universally in the Python standard library. In particular there are 636 errors in the standard library ``python pep8.py --select E402 --statistics

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23061 ___ ___

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Ian Lee added the comment: I should add that I would be happy to patch the standard libraries to be compliant w.r.t. the imports at top of the files. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23061

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

Terry J. Reedy added the comment: I read Nick's post and I would like PEP8 to continue to discourage imports at class scope unless there is actually a use case. I discovered yesterday that idlelib.ColorDelegator has several imports at the top of the module and more as the top of the class

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

New submission from Ian Lee: Minor update pep8 to specify explicitly that Imports at top of file refers specifically to module level imports, per input from Nick Coghlan @ https://github.com/jcrocholl/pep8/pull/304#issuecomment-66939162 -- assignee: docs@python components: