R. David Murray added the comment:
Looks like Serhiy forgot to close this, so closing it.
--
assignee: serhiy.storchaka -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
R. David Murray added the comment:
No, I just had a stale tab :( :(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
___
Roundup Robot added the comment:
New changeset cf5b62036445 by Serhiy Storchaka in branch 'default':
Issue #23171: csv.Writer.writerow() now supports arbitrary iterables.
https://hg.python.org/cpython/rev/cf5b62036445
--
nosy: +python-dev
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
Martin Panter added the comment:
Left a question about handling of the unquoted empty field exception on
Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
___
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
The docs mention that row should be a sequence, so there is no a bug.
Here is a patch which makes writerow() accept an iterable without converting it
to a list. It also adds tests for few corner cases and fixes the docs.
--
nosy: +serhiy.storchaka
R. David Murray added the comment:
Hmm. That could be an issue. If someone passes a generator they will
generally expect it to be consumed as a generator, not turned into a list
implicitly. So it may be better to turn this into a doc bug and require the
explicit list call :(.
--
New submission from Jon Dufresne:
The csv.writer.writerow() does not accept a generator as input. I find this
counter-intuitive and against the spirit of similar APIs. If the generator is
coerced to a list, everything works as expected. See the following test script
which fails on the line
Jon Dufresne added the comment:
I have created an initial patch such that writerow() now allows generators. I
have also added a unit test to demonstrate the fix.
The code now coerces iterators (and generators) to a list, then operates on the
result. I would have preferred to simply iterate
R. David Murray added the comment:
This seems like a sensible enhancement request to me.
It is possible it could even be considered a bug, the docs aren't exactly clear
on what 'row' is expected to be.
--
keywords: +easy
nosy: +r.david.murray
stage: - needs patch
type: behavior -
13 matches
Mail list logo
