Changes by Terry J. Reedy tjre...@udel.edu:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23184
___
Roundup Robot added the comment:
New changeset 8875d7c6a99d by Terry Jan Reedy in branch '2.7':
Issue #23184: idle tests, remove unused names and imports.
https://hg.python.org/cpython/rev/8875d7c6a99d
New changeset 526ce81f700d by Terry Jan Reedy in branch '3.4':
Issue #23184: idle tests,
Roundup Robot added the comment:
New changeset d50d661a08f5 by Terry Jan Reedy in branch '2.7':
Issue #23184: idlelib, remove more unused names and imports.
https://hg.python.org/cpython/rev/d50d661a08f5
New changeset 777569dd4bca by Terry Jan Reedy in branch '3.4':
Issue #23184: idlelib,
Terry J. Reedy added the comment:
I got hg working and pushed the patch I had in January as a980da5f79f9,
5386aedf3ac9, 15701e89d710, and 3fa58e779308. Having forgotten that this issue
was on the tracker (rather than just idle-sig post), I omitted the issue number
and acknowledgement for the
Terry J. Reedy added the comment:
News entry, not new entry (Cannot edit commit messages)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23184
___
Terry J. Reedy added the comment:
More idlelib fixes. Will push after reviewing. pyflakes shows extraneous items
in idle_test also.
--
Added file: http://bugs.python.org/file39375/@unused.diff
___
Python tracker rep...@bugs.python.org
Changes by Terry J. Reedy tjre...@udel.edu:
Added file: http://bugs.python.org/file39376/@unused27.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23184
___
Al Sweigart added the comment:
*more transparent, that is. Not opaque.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23184
___
___
Al Sweigart added the comment:
I've updated the patch.
I've removed the EditorWindow deletion. Importing that and using it as a class
variable instead of using an assignment statement wasn't picked up. (Is there a
more opaque way to do this import?)
I've left the RemoteDebugger.py change in.
New submission from Al Sweigart:
The IDLE code base has several unused imports and local variables. The
testcode.py file seems to have been accidentally checked in.
These changes were found through a lint program, not by hand. All idle unit
tests pass after these changes.
--
Changes by Al Sweigart asweig...@gmail.com:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23184
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 1c3f8d044589 by Terry Jan Reedy in branch '2.7':
Issue #23184: delete unused idlelib file.
https://hg.python.org/cpython/rev/1c3f8d044589
New changeset 364e44a49a31 by Terry Jan Reedy in branch '3.4':
Issue #23184: delete unused idlelib file.
Terry J. Reedy added the comment:
There were errors in the patch.
FileList.py: EditorWindow is used later.
RemoteDebugger.py: frame is used twice, as visible in the diff.
My copy of hg is not working right at the moment, or I would have applied the
rest.
--
Terry J. Reedy added the comment:
I am aware of some of these from running PyChecker over idlelib, but had not
gotten around to an global patch yet. The unit test coverage is still woefully
incomplete, so I will want to check each deletion.
I have been meaning to delete testcode.py, but in a
14 matches
Mail list logo
