[issue23228] Crashes when tarfile contains a symlink and unpack directory contain it too

2016-05-04 Thread Michael Vogt
Michael Vogt added the comment: Anything I can do to help moving this issue forward? -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue23228] Crashes when tarfile contains a symlink and unpack directory contain it too

2015-01-19 Thread Michael Vogt
Michael Vogt added the comment: Thanks SilentGhost for your feedback and sorry for my slow reply. I looked into this some more and attached a updated patch with a more complete test. It also covers a crash now that happens when there is a symlink cycle in the tar and on disk. My fix is to re

[issue23228] Crashes when tarfile contains a symlink and unpack directory contain it too

2015-01-13 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23228] Crashes when tarfile contains a symlink and unpack directory contain it too

2015-01-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +lars.gustaebel, serhiy.storchaka stage: -> patch review versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___

[issue23228] Crashes when tarfile contains a symlink and unpack directory contain it too

2015-01-13 Thread SilentGhost
SilentGhost added the comment: Perhaps I'm missing something here, but it doesn't seem to be a problem with valid links. Only invalid symlinks are causing this issue. -- nosy: +SilentGhost ___ Python tracker _

[issue23228] Crashes when tarfile contains a symlink and unpack directory contain it too

2015-01-13 Thread Michael Vogt
Michael Vogt added the comment: This patch contains a regression test as well. -- Added file: http://bugs.python.org/file37690/possible-fix-23228-with-test.diff ___ Python tracker __

[issue23228] Crashes when tarfile contains a symlink and unpack directory contain it too

2015-01-13 Thread Michael Vogt
Michael Vogt added the comment: A possible fix that works with the previous testcase for this bug. It does not break a tarfile tests. -- keywords: +patch Added file: http://bugs.python.org/file37689/possible-fix-37688.diff ___ Python tracker

[issue23228] Crashes when tarfile contains a symlink and unpack directory contain it too

2015-01-13 Thread Michael Vogt
New submission from Michael Vogt: The tarfile.makelink() code crashes with a maximum recursion error when it unpacks a tarfile that contains a symlink into a directory that already contains this symlink. Attached is a standalone testcase (that probably better explains whats going on :) and a