[issue23253] Delay-load ShellExecute

2015-01-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5bff604a864e by Steve Dower in branch 'default': Closes #23253: Delay-load ShellExecute https://hg.python.org/cpython/rev/5bff604a864e -- nosy: +python-dev resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue23253] Delay-load ShellExecute

2015-01-24 Thread Steve Dower
Steve Dower added the comment: I assume you're referring to normal_startup and startup_nosite in perf.py at h.p.o/benchmarks? Handy to know about (I need to explore our top-level repos more often, obviously), but probably still not going to measure time in the Windows PE loader as accurately a

[issue23253] Delay-load ShellExecute

2015-01-18 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23253] Delay-load ShellExecute

2015-01-18 Thread Brett Cannon
Brett Cannon added the comment: If you want a robust measurement of startup impact, the benchmark suite has two benchmarks specifically for startup (w/ and w/o site.py). -- ___ Python tracker _

[issue23253] Delay-load ShellExecute

2015-01-17 Thread Steve Dower
Steve Dower added the comment: Yeah, I hate touching posixmodule.c for the same reason. It'd be nice to split it up into separate platform files, but nobody is volunteering for that. If you focus on the performance, then yeah, this change probably isn't worth it. OTOH, the number of Windows pl

[issue23253] Delay-load ShellExecute

2015-01-17 Thread Tim Golden
Tim Golden added the comment: I'm +0.75. I think the idea's fine in principle and the patch (by inspection) seems to do the right things. My only concerns are: that posixmodule.c becomes even longer and more involved; and that the benefit might not quite be great enough to justify the added c

[issue23253] Delay-load ShellExecute[AW] in os.startfile

2015-01-17 Thread Steve Dower
Steve Dower added the comment: Attached a patch. Comparing the time for "python.exe -c '0'" with Powershell's Measure-Command tool, it looks like there's a 3-4ms (~8-10%) improvement in startup time too. That's not at all robust, but it's certainly no worse. (I'm not surprised - shell32.dll i

[issue23253] Delay-load ShellExecute[AW] in os.startfile

2015-01-17 Thread Steve Dower
Changes by Steve Dower : -- assignee: -> steve.dower stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23253] Delay-load ShellExecute[AW] in os.startfile

2015-01-16 Thread Steve Dower
New submission from Steve Dower: Currently, pythonXY.dll has a dependency on shell32.dll solely for the os.startfile (Modules/posixmodule.c) function. This is quite a heavy dependency that many would rather not have to load (e.g. lightweight server configurations). It would be nice to delay l