Steve Dower added the comment:
I haven't seen any of these in a while, and the buildbot at
http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x (the only one
running VS 2015 right now AFAIK) hasn't either, so I'm calling this fixed.
--
resolution: - fixed
status: open -
Changes by David Bolen db3l@gmail.com:
--
nosy: +db3l
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23314
___
___
Python-bugs-list mailing
STINNER Victor added the comment:
23314_tf_inherit_check.diff: I would prefer to see this complex code in a
function of the support module. For example, the SuppressCrashReport class is a
good candidate.
--
___
Python tracker rep...@bugs.python.org
Steve Dower added the comment:
You're right, SuppressCrashReport also makes more sense here, though it still
needs to be used explicitly in every new process. New patch attached.
--
Added file: http://bugs.python.org/file38210/23314_tf_inhert_check_2.diff
Steve Dower added the comment:
Having run some more tests, it may be that the only regular problem is in the
test for inherited file descriptors.
I've attached a patch for tf_inherit_check.py that will prevent assert dialogs.
It's not pretty, but it avoids touching the interpreter internals.
STINNER Victor added the comment:
When we completely switch Windows builds over to VC14, we're going to
encounter some new assert dialogs from the CRT. (...) A number of tests attempt
operations on bad file descriptors, which will assert and terminate in MSVCRT
(I have a fix for the
Steve Dower added the comment:
_Py_verifyfd has to go away, unfortunately. It requires inside knowledge of the
exact CRT version, and with VC14 the CRT will automatically upgrade so that
we're always using the latest.
I've gotten a function added to the CRT to make it unnecessary for release
STINNER Victor added the comment:
An environment variable is an easy way to make sure that all
subprocesses also have assert dialogs disabled. In release builds they
are always disabled, hence the _DEBUG check.
If _PyVerify_fd() must go, I would prefer to always disable CRT check.
Otherwise,
Steve Dower added the comment:
To be clearer (while still respecting the confidentiality agreement I'm under),
previously this code would (if _DEBUG) display an assertion dialog and
(regardless of _DEBUG) terminate the process:
close(fd); // succeeds, assuming a good fd
close(fd); //
Steve Dower added the comment:
EBADF will still be returned; _PyVerify_fd is only there to prevent the
assertion dialogs in debug builds. Release builds will not need _PyVerify_fd at
all (though it's public, so it will remain, but it won't be necessary to
protect calls into the CRT). As I
Steve Dower added the comment:
Attached a patch with options 1 and 2 implemented - both are fairly trivial.
Any thoughts/preferences?
--
assignee: - steve.dower
keywords: +patch
Added file: http://bugs.python.org/file38104/23314 Options.patch
___
New submission from Steve Dower:
When we completely switch Windows builds over to VC14, we're going to encounter
some new assert dialogs from the CRT. These won't appear in release builds, but
because the buildbots run tests against debug builds they will get in the way.
A number of tests
12 matches
Mail list logo
