[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-09-27 Thread Roundup Robot
Roundup Robot added the comment: New changeset 38a5b0f6531b by Benjamin Peterson in branch '3.5': detect alpn by feature flag not openssl version (closes #23329) https://hg.python.org/cpython/rev/38a5b0f6531b New changeset 747996431c7e by Benjamin Peterson in branch 'default': merge 3.5

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-09-26 Thread Remi Pointel
Remi Pointel added the comment: Good, I think we should test on a machine with a version of openssl that does not support ALPN to be sure. -- ___ Python tracker

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-09-25 Thread Martin Panter
Martin Panter added the comment: I just tested your patch on Arch Linux with the default 3.6 Python branch. The test suite passed happily and all seems to be well: Python 3.6.0a0 (python_have_alpn.diff qbase qtip tip:eb8ee60ace13, Sep 25 2015, 22:53:15) [GCC 5.1.0] on linux Type "help",

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-09-23 Thread Remi Pointel
Remi Pointel added the comment: With this patch it works fine on OpenBSD with LibreSSL. Could you test on a Linux machine with OpenSSL supporting ALPN please? Thanks spil@ for the idea. -- keywords: +patch Added file: http://bugs.python.org/file40556/python_have_alpn.diff

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-09-23 Thread Bernard Spil
Bernard Spil added the comment: Checking if the method is actually defined is the smart way to go >From include/openssl/tls1.h # define TLSEXT_TYPE_application_layer_protocol_negotiation So #ifdef TLSEXT_TYPE_application_layer_protocol_negotiation would show you if the feature is available

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-09-23 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-09-22 Thread Remi Pointel
Remi Pointel added the comment: Maybe we could check if the functionality is available instead of checking a version? What do you think about that? -- ___ Python tracker

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-09-22 Thread Bernard Spil
Bernard Spil added the comment: ALPN was removed originally but added again later http://marc.info/?l=openbsd-announce=142193407304782 -- ___ Python tracker

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-01-27 Thread STINNER Victor
New submission from STINNER Victor: Recently, the issue #20188 ALPN support for TLS was fixed. The problem is that the check for the ALPN feature doesn't work with LibreSSL: /* ALPN added in OpenSSL 1.0.2 */ #if OPENSSL_VERSION_NUMBER = 0x1000200fL !defined(OPENSSL_NO_TLSEXT) # define

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-01-27 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23329 ___

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-01-27 Thread Benjamin Peterson
Benjamin Peterson added the comment: (Thanks for pointing out the problem and the fix.) -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23329 ___

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-01-27 Thread Roundup Robot
Roundup Robot added the comment: New changeset 53e94a687570 by Benjamin Peterson in branch 'default': disable ALPN on LibreSSL, which has a large version number, but not ALPN support (closes #23329) https://hg.python.org/cpython/rev/53e94a687570 New changeset f7fd2776e80d by Benjamin Peterson

[issue23329] _ssl cannot be compiled with LibreSSL anymore (on OpenBSD 5.5) because of ALPN

2015-01-27 Thread STINNER Victor
STINNER Victor added the comment: Cool, the issue looks like the issue has been fixed: the _ssl module can be build again. http://buildbot.python.org/all/builders/x86%20OpenBSD%205.5%203.x/builds/1334/steps/compile/logs/stdio Thanks for the quick fix. --