Roundup Robot added the comment:
New changeset 973c9ec53bbb by Serhiy Storchaka in branch 'default':
Fixed the array module broken in issue #23492.
https://hg.python.org/cpython/rev/973c9ec53bbb
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset e10ad4d4d490 by Serhiy Storchaka in branch 'default':
Issue #23492: Argument Clinic now generates argument parsing code with
https://hg.python.org/cpython/rev/e10ad4d4d490
--
nosy: +python-dev
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23492
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Argument Clinic
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23492
___
___
Antoine Pitrou added the comment:
Let's make Argument Clinic a fierce optimizer!
(+1 on this)
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23492
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
dependencies: +Argument Clinic: generate code into separate files by default
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23492
Stefan Behnel added the comment:
Serhiy, I suggest you look at the code that Cython generates for its functions.
It has been extensively profiled and optimised (years ago), so generating the
same code for the argument clinic should yield the same performance.
And while I don't have exact
Larry Hastings added the comment:
Stefan: Serhiy's patch only affects functions taking a single positional-only
parameter.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23492
___
Serhiy Storchaka added the comment:
Serhiy, I suggest you look at the code that Cython generates for its
functions. It has been extensively profiled and optimised (years ago), so
generating the same code for the argument clinic should yield the same
performance.
Thanks, I'll look on it.
Larry Hastings added the comment:
lgtm
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23492
___
___
Python-bugs-list mailing list
Unsubscribe:
Serhiy Storchaka added the comment:
After expanding PyArg_Parse for i and D codes above tests give following
results:
$ ./python -m timeit chr(0x20ac)
100 loops, best of 3: 0.558 usec per loop
$ ./python -m timeit -s from cmath import isnan; x = 1j -- isnan(x)
100 loops, best of 3:
New submission from Serhiy Storchaka:
Proposed patch improve generated parsers for functions with single positional
argument. Now they always generated as METH_O and PyArg_Parse() is used to
parse single argument.
To avoid code churn in this and following changes it would be worth to extract
Changes by Josh Rosenberg shadowranger+pyt...@gmail.com:
--
nosy: +josh.r
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23492
___
___
Larry Hastings added the comment:
I'm not opposed to the patch in principle. I assume your goal is to make
Python faster--do you have any data on how much faster?
I don't support immediately changing all uses of Argument Clinic to generate
their code into a separate file. I would want to
Serhiy Storchaka added the comment:
This is one step on long way. Second step will be to inline PyArg_Parse for
some format codes (i, U, y*, O, O!). Then we could try to expand
PyArg_ParseTuple, at least for simple common cases. Then
PyArg_ParseTupleAndKeywords. All this step will produce
15 matches
Mail list logo
