[issue23694] PEP 475: handle EINTR in fileutils.c

Roundup Robot added the comment: New changeset 2e1234208bab by Victor Stinner in branch 'default': Issue #23694: Fix usage of _Py_open() in the _posixsubprocess module https://hg.python.org/cpython/rev/2e1234208bab -- ___ Python tracker

[issue23694] PEP 475: handle EINTR in fileutils.c

Roundup Robot added the comment: New changeset ed25e945cdc2 by Victor Stinner in branch 'default': Issue #23694: Handle EINTR in _Py_open() and _Py_fopen_obj() https://hg.python.org/cpython/rev/ed25e945cdc2 -- ___ Python tracker

[issue23694] PEP 475: handle EINTR in fileutils.c

STINNER Victor added the comment: All functions which can fail with EINTR now retries the function on EINTR. I close the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker __

[issue23694] PEP 475: handle EINTR in fileutils.c

STINNER Victor added the comment: Charles-François Natali added the comment: > Note that dup() cannot fail with EINTR, it is non-blocking: dup2() can > fail, because f the target FD is open, it has to close it, but not > dup(). Oh right, I misread the manual page. I will leave _Py_dup() unchange

[issue23694] PEP 475: handle EINTR in fileutils.c

Charles-François Natali added the comment: LGTM. Note that dup() cannot fail with EINTR, it is non-blocking: dup2() can fail, because f the target FD is open, it has to close it, but not dup(). See e.g. this man page from my Debian: EINTR The dup2() or dup3() call was interrupted by a s

[issue23694] PEP 475: handle EINTR in fileutils.c

Changes by STINNER Victor : -- nosy: +neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue23694] PEP 475: handle EINTR in fileutils.c

STINNER Victor added the comment: fileutils_eintr.patch: handle EINTR for open, fopen and dup (only on Linux for dup in _Py_dup). _Py_wfopen() and _Py_fopen() are not modified because callers are not really prepared to handle exceptions. These functions are mostly used during early steps of P

[issue23694] PEP 475: handle EINTR in fileutils.c

Roundup Robot added the comment: New changeset cfe541c694f3 by Victor Stinner in branch 'default': Issue #23694: Enhance _Py_fopen(), it now raises an exception on error https://hg.python.org/cpython/rev/cfe541c694f3 -- ___ Python tracker

[issue23694] PEP 475: handle EINTR in fileutils.c

Roundup Robot added the comment: New changeset 0b99d7043a99 by Victor Stinner in branch 'default': Issue #23694: Enhance _Py_open(), it now raises exceptions https://hg.python.org/cpython/rev/0b99d7043a99 -- nosy: +python-dev ___ Python tracker

[issue23694] PEP 475: handle EINTR in fileutils.c

New submission from STINNER Victor: fileutils.c must be modified to retry when a function fails with EINTR: see the PEP 475. I'm working on a patch. -- messages: 238358 nosy: haypo priority: normal severity: normal status: open title: PEP 475: handle EINTR in fileutils.c versions: Pyth