[issue2373] Raise Py3K warnings for comparisons that changed

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2373] Raise Py3K warnings for comparisons that changed

Steven Bethard <[EMAIL PROTECTED]> added the comment: Resolved in revision 61570. I can't get svnmerge block to work though. Since the code and method changes are just backports of Python 3, someone needs to run ``svnmerge.py block -r 61570``. __ Tracker <[EMAIL P

[issue2373] Raise Py3K warnings for comparisons that changed

Steven Bethard <[EMAIL PROTECTED]> added the comment: I took a closer look at sliceobject.c and it looks like both 2.6 and 3.0 compare them basically as tuples. So there don't need to be any warnings about using < and > since these are still well defined. I'll have a patch for codeobject.c and m

[issue2373] Raise Py3K warnings for comparisons that changed

Steven Bethard <[EMAIL PROTECTED]> added the comment: Ok, that warning should be gone now in trunk. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-lis

[issue2373] Raise Py3K warnings for comparisons that changed

Steven Bethard <[EMAIL PROTECTED]> added the comment: So I believe it should be returning -2 instead of NULL. Can someone verify that -2 means raise an exception for tp_compare? __ Tracker <[EMAIL PROTECTED]> ___

[issue2373] Raise Py3K warnings for comparisons that changed

Steven Bethard <[EMAIL PROTECTED]> added the comment: On Tue, Mar 18, 2008 at 11:57 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Your patch kicks up warnings in Objects/cellobject.c because > cell_compare returns an int, your p

[issue2373] Raise Py3K warnings for comparisons that changed

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Your patch kicks up warnings in Objects/cellobject.c because cell_compare returns an int, your patch may return NULL. -- nosy: +benjamin.peterson __ Tracker <[EMAIL PROTECTED]>

[issue2373] Raise Py3K warnings for comparisons that changed

Steven Bethard <[EMAIL PROTECTED]> added the comment: Revision 61529 adds warnings for object, type, cell and dict comparisons. The code, method and slice warnings are still needed. __ Tracker <[EMAIL PROTECTED]>

[issue2373] Raise Py3K warnings for comparisons that changed

Steven Bethard <[EMAIL PROTECTED]> added the comment: I'm attaching a patch that handles object comparisons, type comparisons, cell comparisons, and dict comparisons. All the tests pass (including the new ones I've added) but I'd appreciate it if someone could take a second look. Other things st

[issue2373] Raise Py3K warnings for comparisons that changed

New submission from Steven Bethard <[EMAIL PROTECTED]>: Some comparisons were changed or removed in Python 3.0. In 2.6 you could compare types (e.g. ``str < int``) and dicts supported more than just equality. These comparisons should produce Py3K warnings. -- assignee: bethard components