[issue23752] Cleanup io.FileIO

STINNER Victor added the comment: Buildbot issues were unrelated and have been fixed. I close the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue23752] Cleanup io.FileIO

STINNER Victor added the comment: Oh, there was another hang before, so it's probably not related: http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/2852/steps/test/logs/stdio [393/393] test_ssl Timeout (1:00:00)! Thread 0x000102d81000 (most recent call first): File

[issue23752] Cleanup io.FileIO

STINNER Victor added the comment: The changeset 128f92ae8bae also changed _Py_fstat() to release the GIL when calling fstat(), I forgot to mention it in the changeset. test_socket now hangs on AMD64 Snow Leop 3.x, I don't know yet if it's related: http://buildbot.python.org/all/builders/AMD64%

[issue23752] Cleanup io.FileIO

Roundup Robot added the comment: New changeset 128f92ae8bae by Victor Stinner in branch 'default': Issue #23752: _Py_fstat() is now responsible to raise the Python exception https://hg.python.org/cpython/rev/128f92ae8bae -- ___ Python tracker

[issue23752] Cleanup io.FileIO

STINNER Victor added the comment: Hum, _Py_fstat() is not used correctly in _io.FilIO: it uses errno instead of GetLastError() to raise the OSError. It's too hard to use the new _Py_fstat() function directly, I modified it to raise directly the exception. So the caller doesn't have to use #ifd

[issue23752] Cleanup io.FileIO

Roundup Robot added the comment: New changeset bc2a22eaa0af by Victor Stinner in branch 'default': Issue #23752: When built from an existing file descriptor, io.FileIO() now only https://hg.python.org/cpython/rev/bc2a22eaa0af -- nosy: +python-dev ___

[issue23752] Cleanup io.FileIO

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue23752] Cleanup io.FileIO

Changes by Piotr Dobrogost : -- nosy: +piotr.dobrogost ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue23752] Cleanup io.FileIO

STINNER Victor added the comment: See also issue #21861: "io class name are hardcoded in reprs". In my review of _pyio.FileIO, I asked if it would be possible to use __qualname__ in __getstate__(). -- ___ Python tracker

[issue23752] Cleanup io.FileIO

STINNER Victor added the comment: The previous change related to fstat() is the changeset 3b5279b5bfd1 from the issue #21679. The changeset introduces the private _blksize attribute. The strange thing is that the changelog is: "Issue #21679: Prevent extraneous fstat() calls during open(). Patc

[issue23752] Cleanup io.FileIO

STINNER Victor added the comment: fileio_drop_dup_fstat.patch: Remove the duplicate call to fstat() in fileio.c. Tests pass, invalid FD are still detected since there is a second call to fstat() which also raises OSError(EBADF) if fstat(fd) fails. -- keywords: +patch Added file: http:/

[issue23752] Cleanup io.FileIO

New submission from STINNER Victor: While reviewing a Python implementation of io.FileIO (_pyio.FileIO) in the issue #21859, many issues were found in the C implementation. I open an issue to fix them. We may fix them before or after the Python implementation is merged. -- components: