Roundup Robot added the comment:
New changeset fe55a36a335b by Robert Collins in branch '3.4':
Issue #23779: imaplib raises TypeError if authenticator tries to abort.
https://hg.python.org/cpython/rev/fe55a36a335b
New changeset b6f04b9d8c12 by Robert Collins in branch '3.5':
Issue #23779:
Robert Collins added the comment:
Thanks for the patch. Applied to 3.4 through 3.6.
--
nosy: +rbcollins
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Looks good to me, thanks.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23779
___
R. David Murray added the comment:
The patch looks good to me, except that I think it would be better if the test
verified that the '*' response is received by the server (perhaps return OK if
we don't get it?)
--
components: +email
nosy: +barry, r.david.murray
stage: test needed -
Craig Holmquist added the comment:
Okay, I attached another patch. The new version of the test returns success if
the client's response is anything other than the abort line (*\r\n).
It fails with the current version of imaplib, fails if I change
_Authenticator.process to output a
Craig Holmquist added the comment:
New patch is attached.
--
Added file: http://bugs.python.org/file38749/imap_auth2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23779
___
Berker Peksag added the comment:
Thanks for the report and the patch, Craig. Could you convert your reproducer
to a test case? imaplib tests are located in Lib/test/test_imaplib.py.
--
nosy: +berker.peksag
versions: +Python 3.5
___
Python tracker
Changes by Eric V. Smith e...@trueblade.com:
--
stage: - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23779
___
___
Python-bugs-list
Changes by Eric V. Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23779
___
___
Python-bugs-list
New submission from Craig Holmquist:
If the authenticator object passed to the IMAP authenticate method tries to
abort the handshake by returning None, TypeError is raised instead of sending
the * line to the server.
import imaplib
imap = imaplib.IMAP4_SSL('imap.gmail.com')
10 matches
Mail list logo