[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-07-27 Thread Roundup Robot
Roundup Robot added the comment: New changeset cd60eccaa331 by Victor Stinner in branch '3.5': Issue #24732, #23834: Fix sock_accept_impl() on Windows https://hg.python.org/cpython/rev/cd60eccaa331 -- ___ Python tracker rep...@bugs.python.org

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 462680f4e8af by Victor Stinner in branch 'default': Issue #23834: Fix the default socket timeout https://hg.python.org/cpython/rev/462680f4e8af -- ___ Python tracker rep...@bugs.python.org

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7f54676348d3 by Victor Stinner in branch 'default': Issue #23834: Fix initial value of the socket timeout https://hg.python.org/cpython/rev/7f54676348d3 -- ___ Python tracker rep...@bugs.python.org

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7a9c49885cd3 by Victor Stinner in branch 'default': Issue #23834: Simplify timeout handling https://hg.python.org/cpython/rev/7a9c49885cd3 -- ___ Python tracker rep...@bugs.python.org

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-02 Thread STINNER Victor
STINNER Victor added the comment: The changeset 920b700d9509 fixed AMD64 Snow Leop 3.x, I close the issue. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23834

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 29c32ca46652 by Victor Stinner in branch '2.7': Issue #23834: Fix socket.sendto(), use the C long type to store the result of https://hg.python.org/cpython/rev/29c32ca46652 New changeset 436bb7ad6349 by Victor Stinner in branch '3.4': Issue #23834:

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-01 Thread STINNER Victor
STINNER Victor added the comment: sock_call-2.patch: add an inner looop in sock_call() to only retry func() when func() is interrupted by a signal. Limit also changes: try to only modify ctx around to call to sock_call(), move back some variables to the parent function. Rename the variable

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 920b700d9509 by Victor Stinner in branch 'default': Issue #23834: Fix sock_call(), set deadline_initialized to recompute the timeout https://hg.python.org/cpython/rev/920b700d9509 -- ___ Python tracker

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset b3c7ae99b8e0 by Victor Stinner in branch 'default': Issue #23834: Modify socket.sendall() to reuse sock_call() with https://hg.python.org/cpython/rev/b3c7ae99b8e0 -- ___ Python tracker

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 358a2bcd0d0b by Victor Stinner in branch 'default': Issue #23834: Add sock_call() helper function https://hg.python.org/cpython/rev/358a2bcd0d0b -- nosy: +python-dev ___ Python tracker

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-01 Thread STINNER Victor
STINNER Victor added the comment: Snow Leopard doesn't like me (or the opposite?), the changeset 358a2bcd0d0b introduced a regression. I'm unable to reproduce, I ran test_socket on Linux (3.18), Mac OS X (Yosemite, Mac OS X 10.10) and FreeBSD (10). I don't see a significant difference in

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-03-31 Thread STINNER Victor
New submission from STINNER Victor: With the PEP 475, the BEGIN_SELECT_LOOP and END_SELECT_LOOP macros of Modules/socketmodule.c became complex. Moreover, they are misused to handle EINTR. Most functions currently reimplemented their own loop inside the existing select loop, and so the

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-03-31 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: Added file: http://bugs.python.org/file38770/sock_call.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23834 ___

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-03-31 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: Removed file: http://bugs.python.org/file38769/sock_call.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23834 ___

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-03-31 Thread STINNER Victor
STINNER Victor added the comment: By the way, socket.sendto() has a bug: it stores the result of sendto() into a C int. It must store the result into a Py_ssize_t. sock_call.patch already contains a fix for this. Attached sendto_ssizet.patch is the fix for Python 2.7 and 3.4. UDP packets

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-03-31 Thread STINNER Victor
STINNER Victor added the comment: I chose to not modify yet socket.sendall(). I prefer to wait until this patch is merged to rework this method. Currently, this method never recomputes the timeout. -- ___ Python tracker rep...@bugs.python.org