[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

Change by Zackery Spytz : -- nosy: +ZackerySpytz versions: +Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker ___

[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

Change by Zackery Spytz : -- pull_requests: +6668 ___ Python tracker ___ ___

[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

Bill Parker added the comment: At the moment, I'm not sure if it's needed or not, but if it's only an issue with XP, then it might not be worth fixing...:) On Thu, Apr 9, 2015 at 1:35 PM, STINNER Victor rep...@bugs.python.org wrote: STINNER Victor added the comment: /* Win9x appears to

[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

STINNER Victor added the comment: /* Win9x appears to need us seeked to zero */ lseek(fileno, 0, SEEK_SET); Hum, is it still needed in 2015 with Python 3.5? We even dropped support for Windows XP. -- ___ Python tracker rep...@bugs.python.org

[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

Berker Peksag added the comment: Thanks for the patch, Bill. If you want to work on similar issues see also issue 15948. -- components: +Extension Modules -Interpreter Core nosy: +berker.peksag, haypo, serhiy.storchaka stage: - patch review versions: +Python 3.5

[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

Bill Parker added the comment: I would check 23855 as well, since the malloc() missing a sanity check, which could be a more serious issue .. On Sat, Apr 4, 2015 at 1:32 AM, Berker Peksag rep...@bugs.python.org wrote: Berker Peksag added the comment: Thanks for the patch, Bill. If you want

[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

New submission from Bill Parker: Hello All, In reviewing code in directory Python-3.4.3/Modules, file 'mmapmodule', I found a call to 'lseek()' without a check for a return value of -1, indicating failure. The patch file below corrects this issue (diff -u format): --- mmapmodule.c.orig