[issue23867] Argument Clinic: inline parsing code for 1-argument functions

STINNER Victor added the comment: Nice optimization! I wanted to implement it, but then I forgot. -- ___ Python tracker ___ ___

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Serhiy Storchaka added the comment: See issue35582 for next step. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Serhiy Storchaka added the comment: New changeset 32d96a2b5bc3136d45a66adbdb45fac351b520ce by Serhiy Storchaka in branch 'master': bpo-23867: Argument Clinic: inline parsing code for a single positional parameter. (GH-9689)

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Change by Ammar Askar : -- nosy: +ammar2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

STINNER Victor added the comment: I'm a little bit sad that the PR doesn't add new tests :-( -- ___ Python tracker ___ ___

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Serhiy Storchaka added the comment: Thank you all for your comments. Addressed all comments, fixed few other bugs, added support for more convertors. I think this patch is completed. This is just a first step. Next steps are adding support of multiple positional-only parameters, optional

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Change by Serhiy Storchaka : -- pull_requests: +9076 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

STINNER Victor added the comment: I like the idea since I just proposed something similar in the issue #29419, but it seems like your change removes the function name from error messages which can become much more obscure. Maybe we should wrap all exceptions into a new TypeError which

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Changes by Serhiy Storchaka : -- stage: patch review -> needs patch ___ Python tracker ___

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Serhiy Storchaka added the comment: Because new generated code contains "if" statements and braces (and PEP 7 requires even more braces than current patch adds). The patch for issue26305 allows to repeat braces only twice instead of 4 times. -- ___

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Larry Hastings added the comment: Why is this dependent on #26305? -- ___ Python tracker ___ ___

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Changes by Serhiy Storchaka : -- dependencies: +Argument Clinic incorrectly work with custom converter and renamed parameter, Make Argument Clinic to generate PEP 7 conforming code ___ Python tracker

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

Serhiy Storchaka added the comment: Synchronized with tip. -- versions: +Python 3.6 -Python 3.5 Added file: http://bugs.python.org/file42672/clinic_meth_o_inline.patch ___ Python tracker

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

New submission from Serhiy Storchaka: Proposed patch makes Argument Clinic to inline parsing code for most popular formats in functions with single positional argument. This makes parsing faster. -- components: Argument Clinic files: clinic_meth_o_inline.patch keywords: patch messages: