Roundup Robot added the comment:
New changeset cc2e52878393 by Zachary Ware in branch 'default':
Issue #23911: Fix ctypes test on Windows.
https://hg.python.org/cpython/rev/cc2e52878393
--
___
Python tracker rep...@bugs.python.org
Eric Snow added the comment:
changeset: 95887:3bea670c9830
user:Eric Snow ericsnowcurren...@gmail.com
date:Tue May 05 21:29:31 2015 -0600
summary: Remove an unnecessary flag.
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
Ned Deily added the comment:
This checkin also breaks OS X framework builds. For some reason, framework
builds are compiled with the gcc -fno-common option. The code in configure.ac
to add that option dates back to the initial OS X framework support
(c3c87ce4afdc from 2001). It's not clear
Eric Snow added the comment:
Thanks for pointing this out, Ned. Early on I ran into a problem when running
_freeze_importlib without the flag set. However, I expect that it was not
necessary after a certain point (e.g. once I had a valid
_importlib_external.h). I'll remove the flag as
Larry Hastings added the comment:
This checkin broke the buildbots. If you build trunk then run
./python -bb -m test test_site
the test fails. -bb is used by the normal test runner (make test).
The problem is in the lines
self.assertTrue(os.path.isabs(os__file__),
Roundup Robot added the comment:
New changeset 36b902bbc992 by Eric Snow in branch 'default':
Issue #23911: Fix mixed bytes/strings.
https://hg.python.org/cpython/rev/36b902bbc992
--
___
Python tracker rep...@bugs.python.org
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
resolution: - fixed
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
___
Eric Snow added the comment:
As I mentioned, I'm pretty sure that the failing venv test is due to the
bundled pip. Here's the test output:
test test_venv failed -- Traceback (most recent call last):
File /home/esnow/projects/cpython/Lib/test/test_venv.py, line 356, in
test_with_pip
Eric Snow added the comment:
Looks like setuptool's pkg_resources is directly importing
importlib._bootstrap. I've filed a bug:
https://bitbucket.org/pypa/setuptools/issue/378. In the meantime, what are our
options for getting that test passing?
--
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file: http://bugs.python.org/file39271/path-based-importlib.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
Eric Snow added the comment:
Here's the correct patch.
--
Added file: http://bugs.python.org/file39272/path-based-importlib.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
Nick Coghlan added the comment:
As a compatibility hack for setuptools versions with the issue, I'd suggest
making importlib._bootstrap.setup alias SourceFileLoader back into
importlib._bootstrap, with an explanation and link to back to this issue in
a comment.
--
Eric Snow added the comment:
Gah. I had tried exactly that but did it in the wrong spot. Here's an updated
patch which fixes the test.
--
Added file: http://bugs.python.org/file39273/path-based-importlib.diff
___
Python tracker
Eric Snow added the comment:
Here's an updated patch with _pathy.py changed to _bootstrap_external.py
(and similar changes with freezing). The patch does not include fixing the
venv test (i.e. the bundled pip).
Also, I'll be adding a note to NEWS.
--
Added file:
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file: http://bugs.python.org/file39273/path-based-importlib.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file: http://bugs.python.org/file39274/path-based-importlib.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
Roundup Robot added the comment:
New changeset 02e3bf65b2f8 by Eric Snow in branch 'default':
Issue #23911: Move path-based bootstrap code to a separate frozen module.
https://hg.python.org/cpython/rev/02e3bf65b2f8
--
nosy: +python-dev
___
Python
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
Added file: http://bugs.python.org/file39274/path-based-importlib.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
Added file: http://bugs.python.org/file39275/path-based-importlib.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
Eric Snow added the comment:
Glad to hear the patch is conceptually consistent with other components. :)
And the internal/external suggestion is a good one. I'll update the patch
when I have a minute.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Nice, this ties directly into one of the thornier problems in the PEP 432
bootstrapping work, which needs to set up the core import system in
Py_BeginInitialization, but delay setting up the rest of it until
Py_EndInitialization.
Your patch achieves this by
Eric Snow added the comment:
Here's an updated patch, with the PEP 489 changes merged in. Only one test
isn't passing and it is due to something in the pip that is bundled into
ensurepip. I'll work on fixing that when I have some time. I'm sure there's
documentation near the bundle that
Eric Snow added the comment:
s/PEP 489/PEP 488/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
___
Python-bugs-list mailing list
Changes by Raúl Cumplido raulcumpl...@gmail.com:
--
nosy: +raulcd
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23911
___
___
Python-bugs-list
New submission from Eric Snow:
The bootstrap code has a clear division between the core import functionality
and the path-based import machinery. The attached patch makes that division
explicit by moving the latter into its own module. The module is also frozen,
necessarily. In addition to
27 matches
Mail list logo
