[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Stefan Krah : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue2394] [Py3k] Finish the memoryview object implementation

Stefan Krah added the comment: I think this issue is now superseded by #10181 and #3132. -- nosy: +skrah resolution: -> duplicate stage: test needed -> committed/rejected status: open -> pending superseder: -> Problems with Py_buffer management in memoryobject.c (and elsewhere?) ___

[issue2394] [Py3k] Finish the memoryview object implementation

R. David Murray added the comment: It looks to me like the critical parts of this have been done, so I'm downgrading the priority. -- nosy: +r.david.murray priority: critical -> high versions: +Python 3.2 -Python 3.1 ___ Python tracker

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Alexander Belopolsky : -- nosy: +belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Antoine Pitrou : -- stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file11155/mem1.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file11156/mem2.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file11157/mem3.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file11158/mem4.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file11159/mem5.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file11166/mem6.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Great. It would be nice if you could at least do a quick review what has been committed though. ___ Python tracker <[EMAIL PROTECTED]>

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Travis Oliphant <[EMAIL PROTECTED]>: -- versions: +Python 3.1 -Python 3.0 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Pyth

[issue2394] [Py3k] Finish the memoryview object implementation

Travis Oliphant <[EMAIL PROTECTED]> added the comment: It would have been nice to finish the memoryview object for 3.0, but I ran into time constraints. The pieces that are left can be pushed to 3.1 ___ Python tracker <[EMAIL PROTECTED]>

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Guido, do we retarget the rest of this to 3.1? It sounds more reasonable to me. -- nosy: +gvanrossum ___ Python tracker <[EMAIL PROTECTED]> __

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r65886 after review from Benjamin and some small fixes. I'm downgrading this to critical for the remains of the memoryview API (support for more format types, multi-dimensional objects...). Perhaps those remainings will have to w

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Please review at http://codereview.appspot.com/3004 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: This patch changes all bytearray results (in indexing, tobytes()) to bytes, and adds the implementation the tolist(). Note: the tolist() implementation only handles one-dimensional byte buffers. It will have to be re-written using the struct

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Adding some comparison tests. Added file: http://bugs.python.org/file11159/mem5.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch to support comparisons of memoryview objects with other objects offering the buffer interface. Two objects are equal if their buffers have the same characteristics and compare equal bytewise. It also improves the test in test_c

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: This patch fixes a crash in the codecs module. However, memoryview should also support comparisons (just == and !=) with bytes/bytearray objects (or any buffer-enabled objects), otherwise utf-8-sig produces wrong values (and there are no tests

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is another patch with setitem too (integers and slices supported), and further tests. Added file: http://bugs.python.org/file11156/mem2.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue2394] [Py3k] Finish the memoryview object implementation

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Antoine, if this is a "cleanup", perhaps you could fix #3101 while you're at it. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a preliminary patch implementing slices with getitem, adding a bunch of tests, and fixing a few problems. As stated elsewhere I only bother to test with simple byte buffers. The semantics of other types of buffers are too fuzzy for me

[issue2394] [Py3k] Finish the memoryview object implementation

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: See also #3560. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing lis

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing

[issue2394] [Py3k] Finish the memoryview object implementation

Georg Brandl <[EMAIL PROTECTED]> added the comment: I agree, buffer interface should be completed before going into rc phase. -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> __

[issue2394] [Py3k] Finish the memoryview object implementation

Stefan Behnel <[EMAIL PROTECTED]> added the comment: Also, the implementation does not follow the revised buffer PEP 3118. It still calls get/releasebuffer(NULL) to acquire a lock, which is no longer allowed by the buffer protocol. I think this should become a release blocker for the last beta.

[issue2394] [Py3k] Finish the memoryview object implementation

Georg Brandl <[EMAIL PROTECTED]> added the comment: Raising priority. -- assignee: -> teoliphant nosy: +georg.brandl priority: -> critical __ Tracker <[EMAIL PROTECTED]> __ _

[issue2394] [Py3k] Finish the memoryview object implementation

Changes by Travis Oliphant <[EMAIL PROTECTED]>: -- title: Finish the memoryview object implementation -> [Py3k] Finish the memoryview object implementation __ Tracker <[EMAIL PROTECTED]>