Antoine Pitrou pit...@free.fr added the comment:
Committed in r71070.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2396
___
Antoine Pitrou pit...@free.fr added the comment:
Here is an updated patch removing memory_str.
I know Py_TPFLAGS_HAVE_NEWBUFFER should be documented, but I'm not sure
where and how (I didn't add it in the first place).
--
Added file: http://bugs.python.org/file13325/memview-trunk3.patch
Benjamin Peterson benja...@python.org added the comment:
Some comments:
- PyBytes_* API is fine.
- memory_str should die.
- Py_TPFLAGS_HAVE_NEWBUFFER needs to be documented.
Otherwise it looks good.
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
Here is a patch. Some remarks:
- I had to disable a few tests in test_memoryview.py, mainly because
array.array does not support the new buffer API in 2.x
- I kept the PyBytes_* aliases in memoryobject.c rather than using the
PyString_*
Changes by Thomas Heller thel...@ctypes.org:
--
nosy: +theller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2396
___
___
Python-bugs-list mailing
Antoine Pitrou pit...@free.fr added the comment:
This new patch includes documentation update and fixes as well.
Added file: http://bugs.python.org/file12679/memview-trunk2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2396
