[issue23960] PyErr_SetImportError doesn't clean up on some errors

2016-04-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5871b48f4c2e by Berker Peksag in branch '3.5': Issue #23960: Cleanup args and kwargs on error in PyErr_SetImportError https://hg.python.org/cpython/rev/5871b48f4c2e New changeset 94471357db08 by Berker Peksag in branch 'default': Issue #23960: Clean

[issue23960] PyErr_SetImportError doesn't clean up on some errors

2016-04-30 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23960] PyErr_SetImportError doesn't clean up on some errors

2016-04-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- nosy: +serhiy.storchaka stage: patch review -> commit review ___ Python tracker ___ ___ P

[issue23960] PyErr_SetImportError doesn't clean up on some errors

2016-04-30 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch. I left review comments on Rietveld (click to the review link above). -- nosy: +berker.peksag stage: -> patch review versions: +Python 3.6 ___ Python tracker

[issue23960] PyErr_SetImportError doesn't clean up on some errors

2015-04-14 Thread Ofer Schwarz
New submission from Ofer Schwarz: When creating kwargs to construct the ImportError, if PyDict_SetItemString fails the function returns without decref'ing the already-created locals. -- components: Interpreter Core files: importerrorcleanup.patch keywords: patch messages: 241052 nosy: b