Changes by Steve Dower steve.do...@microsoft.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23970
___
Marc-Andre Lemburg added the comment:
I was away the last few days, so just found the changes now.
IMO, it's a good idea to use a new module for the new compiler, but don't think
it's a good idea to make the whole module private, since this implicitly
disallows sub-classing the compiler class
Steve Dower added the comment:
I understood it only disallowed complaining about breaking changes without a
deprecation cycle :)
I'm sorry I didn't realize you were away. If you have examples of how
subclassing this class (and not just CCompiler) is useful and does something
that can't be
Mark Lawrence added the comment:
If the name is changed I'd like to see something that doesn't reflect the msvc
version, as my understanding is that from now on the old compatibility issues
are gone.
--
___
Python tracker rep...@bugs.python.org
Changes by Steve Dower steve.do...@microsoft.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23970
___
Roundup Robot added the comment:
New changeset b2ee6206fa5e by Steve Dower in branch 'default':
Issue #23970: Adds distutils._msvccompiler for new Visual Studio versions.
https://hg.python.org/cpython/rev/b2ee6206fa5e
--
nosy: +python-dev
___
Python
Benjamin Peterson added the comment:
b2ee6206fa5e broke every non-Windows buildbot.
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/3229/steps/test/logs/stdio
--
nosy: +benjamin.peterson
resolution: fixed -
status: closed - open
Roundup Robot added the comment:
New changeset 32e6123f9f8c by Steve Dower in branch 'default':
Issue #23970: Fixes bdist_wininst not working on non-Windows platform.
https://hg.python.org/cpython/rev/32e6123f9f8c
--
___
Python tracker
Steve Dower added the comment:
We don't strictly need this for beta 1, but I'd like to get it in. Final call
for feedback (I'll probably hold off checking in until tomorrow morning, ~18
hours from now)
--
___
Python tracker rep...@bugs.python.org
Steve Dower added the comment:
New patch. I've renamed the new class _msvccompiler and changed ccompiler to
use it instead of the old ones.
The old ones are still there to avoid breaking people who were using them
directly, and the old tests are still there too.
Personally, I expect subtle
Marc-Andre Lemburg added the comment:
On 11.05.2015 21:03, Steve Dower wrote:
Steve Dower added the comment:
Simply because I didn't update the doc string :)
I don't really want to put a version number on this file, since it isn't MSVC
14.0 specific - it's MSVC 14 and all future
Paul Moore added the comment:
I agree with Steve, we shouldn't be constrained to preserve all the
undocumented internals of distutils - doing that in the past is what has made
distutils essentially unmaintainable.
I don't think there's a concrete example of real code that will be broken by
Steve Dower added the comment:
I guess we need a third opinion.
For me, the subclasses of CCompiler are undocumented and not a guaranteed
interface (people using them directly are consenting adults). They're also an
eyesore, so if I can clean them up without breaking the CCompiler interface
Marc-Andre Lemburg added the comment:
On 11.05.2015 23:50, Paul Moore wrote:
I agree with Steve, we shouldn't be constrained to preserve all the
undocumented internals of distutils - doing that in the past is what has made
distutils essentially unmaintainable.
I don't think there's a
Steve Dower added the comment:
Simply because I didn't update the doc string :)
I don't really want to put a version number on this file, since it isn't MSVC
14.0 specific - it's MSVC 14 and all future versions. We don't check the build
version anymore, though get_build_version() is still
Marc-Andre Lemburg added the comment:
On 11.05.2015 23:20, Steve Dower wrote:
I guess we need a third opinion.
For me, the subclasses of CCompiler are undocumented and not a guaranteed
interface (people using them directly are consenting adults). They're also an
eyesore, so if I can
Steve Dower added the comment:
Things are already 'broken' for the new compiler version, so Python won't build
properly with older versions of VC anymore (there are a few more changes, like
removing _PyVerify_fd, that will make this even less likely - the new CRT is
for too incompatible with
Marc-Andre Lemburg added the comment:
Why are you removing the mcvs9compiler.py file when at the same time your are
referencing it in the msvccompiler.py doc string ?
--- a/Lib/distutils/msvccompiler.py
+++ b/Lib/distutils/msvccompiler.py
@@ -1,201 +1,120 @@
distutils.msvccompiler
Contains
Steve Dower added the comment:
Any further comments on this? I'd like to get it in for beta (though I don't
believe it's covered by feature freeze).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23970
Steve Dower added the comment:
Made some updates to the patch to use the existing infrastructure for setting
include and library paths, and to fix bdist_wininst.
While it may be worth doing more significant restructuring to help people with
overriding aspects of build, that's almost certainly
Marc-Andre Lemburg added the comment:
On 17.04.2015 00:06, Steve Dower wrote:
So it looks like what I should do is use the include_dirs and library_dirs
members from CCompiler so they can be set through other properties.
I see that you're basically reading the include and lib
dirs from the
Steve Dower added the comment:
Yeah, the basic functionality is no different, since there isn't really a
better way to handle future versions of VS automatically. I'd rather not
officially expose this stuff though.
Maybe you could override the compiler creation code and return an alternative
Marc-Andre Lemburg added the comment:
On 17.04.2015 16:04, Steve Dower wrote:
Yeah, the basic functionality is no different, since there isn't really a
better way to handle future versions of VS automatically. I'd rather not
officially expose this stuff though.
Maybe you could override
Marc-Andre Lemburg added the comment:
We do some monkey-patching on MSVCCompiler as well, but mostly because
distutils doesn't define a good way to subclass or configure a compiler class.
IMO, monkey patching is a really bad idea. distutils should be evolved to
provide more proper extension
Paul Moore added the comment:
Sounds fair enough to me. I guess you have most of the bases covered, and
AFAIK, we've never actually supported building extensions with anything other
than the compiler python.org uses, so that seems a reasonable view to take.
Apart from the numpy/scipy guys,
Paul Moore added the comment:
Hmm, I thought everyone was too scared to change distutils. Brave man :-)
More seriously, I'm not sure I can comment usefully, I don't really understand
any of this code, and the changes are pretty big. I guess the biggest risk is
that someone directly references
Steve Dower added the comment:
Numpy uses a fork of distutils anyway, and currently nobody builds against 3.5
because of the compiler change. There are all sorts of monkey patches out there
against this module and msvc9compiler (I've written some) and those should be
unnecessary now, so I
Steve Dower added the comment:
Is there a way for those users to specify the version that they want? I can
flow that through from somewhere, and honestly the compiler arguments have not
changed in a long time. The problem is detecting an installation.
I have formalized the DISTUTILS_USE_SDK
Changes by Christian Heimes li...@cheimes.de:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23970
___
___
Marc-Andre Lemburg added the comment:
On 16.04.2015 15:18, Steve Dower wrote:
Is there a way for those users to specify the version that they want?
Indirectly, yes. There's the build_ext --compiler argument which then
interfaces to ccompiler.new_compiler. In essence, you can specify
the
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23970
___
___
Steve Dower added the comment:
So it looks like what I should do is use the include_dirs and library_dirs
members from CCompiler so they can be set through other properties.
The extra arguments are passed into compile() as extra_preargs and
extra_postargs, though I'm not entirely sure where
New submission from Steve Dower:
Because of the compiler change, we need to rework the detection of MSVC for
Python 3.5. I took the opportunity to clean up the entire module and remove
msvc9compiler, and updated the tests.
--
assignee: steve.dower
components: Windows
files:
Tim Golden added the comment:
Adding Paul Moore as he's essentially the intersection between distutils
Windows
--
nosy: +paul.moore
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23970
___
34 matches
Mail list logo
