[issue24058] Compiler warning for readline extension

Roundup Robot added the comment: New changeset ec6ed10d611e by Benjamin Peterson in branch '3.4': remove extern definition, since it's in a header file (closes #24058) https://hg.python.org/cpython/rev/ec6ed10d611e New changeset 192f9efe4a38 by Benjamin Peterson in branch '2.7': remove extern de

[issue24058] Compiler warning for readline extension

Masayuki Yamamoto added the comment: I tried another two case changing variable declaration. First case of just removing "extern", Compiler similarly warns, and test passed. Second case of removing "_PyOS_ReadlineTState" declaration, Compiler has not warned, and test passed. First: $ hg diff di

[issue24058] Compiler warning for readline extension

Benjamin Peterson added the comment: Does simply removing the "extern" work? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue24058] Compiler warning for readline extension

Masayuki Yamamoto added the comment: um, Compiler warned, but test passed. It seems a only warning. build log: $ ./configure --prefix=/opt/py34 $ make ... building 'readline' extension gcc -Wno-unused-result -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Werror=declaration-after-statement -

[issue24058] Compiler warning for readline extension

Benjamin Peterson added the comment: What kind of compiler/system does this happen on? -- nosy: +benjamin.peterson ___ Python tracker ___

[issue24058] Compiler warning for readline extension

Masayuki Yamamoto added the comment: Here is a patch modifying variable declaration to same as Include/pytonrun.h. -- keywords: +patch Added file: http://bugs.python.org/file39205/3.4-issue24058-readline-_PyOS_ReadlineTState.patch ___ Python tracker

[issue24058] Compiler warning for readline extension

New submission from Masayuki Yamamoto: Compiler warns case of define HAVE_DECLSPEC_DLL. In Modules/readline.c:1065, _PyOS_ReadlineTState variable declaration is different to Include/pythonrun.h:275. -- components: Build, Extension Modules hgrepos: 307 messages: 242013 nosy: masamoto pri