[issue24217] O_RDWR undefined in mmapmodule.c

Roundup Robot added the comment: New changeset 1838f37a8d9e by Benjamin Peterson in branch '3.4': include fcntl.h on all *nix platforms (closes #24217) https://hg.python.org/cpython/rev/1838f37a8d9e New changeset 25ba5e7af08a by Benjamin Peterson in branch '3.5': Merge 3.4 (#24217) https://hg.py

[issue24217] O_RDWR undefined in mmapmodule.c

Jeffrey Armstrong added the comment: There is a patch attached to this report for greater than 2 months. Should I mark this as "won't fix?" -- ___ Python tracker ___ ___

[issue24217] O_RDWR undefined in mmapmodule.c

Changes by Jeffrey Armstrong : Removed file: http://bugs.python.org/file39407/mmapmodule.py3.5.0a3.diff ___ Python tracker ___ ___ Python-bugs

[issue24217] O_RDWR undefined in mmapmodule.c

Jeffrey Armstrong added the comment: Indeed, I agree. Let's try this new patch. -- Added file: http://bugs.python.org/file39408/mmapmodule.py3.5.0a3.HAVE_FCNTL_H.diff ___ Python tracker __

[issue24217] O_RDWR undefined in mmapmodule.c

Christian Heimes added the comment: I think it's more portable with a #ifdef HAVE_FCNTL_H block around the include. -- nosy: +christian.heimes ___ Python tracker ___

[issue24217] O_RDWR undefined in mmapmodule.c

New submission from Jeffrey Armstrong: While compiling on Linux/x86 with Open Watcom, I've run into the following at link time in Modules/mmapmodule.c: ./Modules/mmapmodule.c(1223): Error! E1011: Symbol 'O_RDWR' has not been declared The constant isn't defined because fcntl.h isn't included.