[issue24250] Optimization for strcpy(..., "") in file 'install.c'

Benjamin Peterson added the comment: I agree with vadmium and also note that many compilers (though I don't know about MSVC) can optimize the strcpy call away. -- nosy: +benjamin.peterson resolution: -> works for me status: open -> closed ___ Python

[issue24250] Optimization for strcpy(..., "") in file 'install.c'

Changes by Serhiy Storchaka : -- priority: normal -> low stage: -> patch review versions: +Python 3.5 -Python 3.4 ___ Python tracker ___

[issue24250] Optimization for strcpy(..., "") in file 'install.c'

Martin Panter added the comment: For the record, the file being patched is PC/bdist_wininst/install.c My opinion is the original is more readable, and unless this is some inner loop bottleneck here it seems like premature optimization. -- nosy: +vadmium ___

[issue24250] Optimization for strcpy(..., "") in file 'install.c'

Paul Moore added the comment: The patch looks fine to me, although I don't think you need the comment showing the old code. The new code is perfectly clear on its own. -- nosy: +paul.moore ___ Python tracker _

[issue24250] Optimization for strcpy(..., "") in file 'install.c'

New submission from Bill Parker: In reviewing calls to strcpy(, ""), I found three instances which could be re-written as * = '\0'; which would save the minor overhead of a function call. The patch file is below: --- install.c.orig 2015-05-20 14:11:27.723397005 -0700 +++ install.c 2015