[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Changes by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior ___ Python tracker ___ _

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Roundup Robot added the comment: New changeset 821663556d87 by Eric Snow in branch 'default': Issue #24320: Drop an old setuptools-induced hack. https://hg.python.org/cpython/rev/821663556d87 -- nosy: +python-dev ___ Python tracker

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Eric Snow added the comment: Hmm. Looks like the fix in setuptools/pkg_resources is 17.0. [1] The bundled pip to which we just updated is 7.0.3, which appears to bundle pkg_resources 15.0. [2] So unless I've misunderstood, the hack will have to linger for a bit longer. Here's a patch for w

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Larry Hastings added the comment: Then you may fire when ready. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Eric Snow added the comment: Yep. test_venv failures is how I found the problem in the first place. -- ___ Python tracker ___ ___ Pyth

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Larry Hastings added the comment: Sounds okay in theory. Is the bug in question now tested in our regression suite? -- ___ Python tracker ___ __

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Eric Snow added the comment: https://hg.python.org/cpython/rev/5c4ba50f6a57 I'll see if that does it. @Larry, would you be opposed to dropping the hack for beta 3? That would mean just deleting the last 2 lines in Lib/importlib/_bootstrap_external.py. --

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Nick Coghlan added the comment: Donald updated 3.5 to pip 7 for the 1st beta, so the relevant fix may have already been included. -- ___ Python tracker ___ _

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Changes by Serhiy Storchaka : -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

Eric Snow added the comment: Would we be okay fixing this in 3.5 as well? I ask because I'm not familiar with the constraints we have on what pip is bundled. -- ___ Python tracker

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

New submission from Eric Snow: In issue #23911 I worked around a bug [1] in pkg_resources (setuptools) which caused test_venv to fail when I split out importlib._bootstrap_external. That bug has now been fixed so we just(?) need to update the version of pip we're bundling and remove the hack