[issue2451] No way to disable socket timeouts in httplib, etc.

2008-05-29 Thread Facundo Batista
Facundo Batista [EMAIL PROTECTED] added the comment: Commited (part of this) patch on r63788. A lot of small details weren't commited, in a big change like this, the best is to minimize the changes. What I have left from this commit, but plan to do it later is a fix to test_urllib2net.py (this

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-04-25 Thread John J Lee
John J Lee [EMAIL PROTECTED] added the comment: Facundo, are you going to review this? __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2451 __ ___ Python-bugs-list mailing list

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-30 Thread John J Lee
John J Lee [EMAIL PROTECTED] added the comment: I've attached a patch. My patch introduces one minor issue: it's an inconvenience when wrapping objects if special default values like socket._GLOBAL_DEFAULT_TIMEOUT are not public. However, I think it's not worth making that special value public

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-30 Thread John J Lee
John J Lee [EMAIL PROTECTED] added the comment: Should I also have selected Python 3.0 from the Versions list, BTW? Don't know what the proper process is ATM... __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2451 __

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-30 Thread John J Lee
John J Lee [EMAIL PROTECTED] added the comment: Me: This should be done in such a way as to also fix the lack of documentation of the None special value in the protocol modules documentation (httplib, etc.). I should have fixed that as part of this patch, but ran out of time -- sorry! Erm,

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-30 Thread Benjamin Peterson
Benjamin Peterson [EMAIL PROTECTED] added the comment: Marking just 2.6 is fine. The fix will be merged into 3.0 -- nosy: +benjamin.peterson __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2451 __

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-27 Thread Facundo Batista
Facundo Batista [EMAIL PROTECTED] added the comment: Mmm it seems that not only overlooked this final agreement, but also forgot it! Bloody brain, :( I'll happily review any proposed patch for this. Alan, maybe you can be persuaded to submit one? .5 wink -- resolution: wont fix -

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-27 Thread John J Lee
John J Lee [EMAIL PROTECTED] added the comment: Great. I'll try to submit a patch this weekend. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2451 __ ___ Python-bugs-list

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-21 Thread John J Lee
New submission from John J Lee [EMAIL PROTECTED]: The new timeout support in 2.6 makes use of new function socket.create_connection(). socket.create_connection() provides no way to disable timeouts, other than by relying on socket.getdefaulttimeout() returning None. This is unfortunate,

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-21 Thread Facundo Batista
Facundo Batista [EMAIL PROTECTED] added the comment: When the semantics of timout in htmllib (and the other libraries) were discussed, the community approved the following behaviour: - setdefaulttimeout() was a hack to allow to set the timeout when nothing else is available. - Now that you can

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-21 Thread John J Lee
John J Lee [EMAIL PROTECTED] added the comment: I see this thread: http://www.gossamer-threads.com/lists/python/dev/552292 But I don't see an explanation of this API decision there that I understand. *Because* socket.setdefaulttimeout() is a hack for when nothing else is available, there

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-21 Thread Facundo Batista
Facundo Batista [EMAIL PROTECTED] added the comment: Two or three threads run in parallel at that time for this issue, don't remember exactly where this was decided. *Because* socket.setdefaulttimeout() is a hack for when nothing else is available, there should be a way to avoid that global