Christian Heimes added the comment:
The issue is already fixed. Python 3.7+ no longer import the md5 module
directly.
--
nosy: +christian.heimes
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
Meador Inge added the comment:
I'm not sure how much this is needed considering hashlib has been around,
since 2.5.
I hope people aren't having to port from before then.
Martin alluded to that when he opened the issue saying this wasn't necessary,
but a nice
to have. However, it has been
Gregory P. Smith added the comment:
Any code conversion is useful. This will help with old libraries and is
even good for just updating old 2.4 code to 2.7 best practices.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
Benjamin Peterson added the comment:
I'm not sure how much this is needed considering hashlib has been around, since
2.5. I hope people aren't having to port from before then.
--
___
Python tracker rep...@bugs.python.org
Meador Inge added the comment:
Attached is a refreshed patch that works for all active branches. The only
real change from the original is Éric's suggestion to s/hash/hashlib/. The 'u'
prefix isn't an issue any longer because of PEP 414.
Benjamin, does the attached look OK to you? If so,
Ezio Melotti added the comment:
What's the status of this?
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Meador Inge added the comment:
I haven't touched the patch since I attached it. I will refresh it today with
the feedback given.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: collinwinter - benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Can this be committed please. In msg110796 I over-emphasised the technical
aspects, the patch is actually against 2to3.
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Minor nit: I suggest naming the fixer fix_hashlib, since the name fix_hash
could easily be understood as something fixing __hash__ (even if such a fix is
impossible for a machine to do).
This fix could also go into fix_imports, but it’s useful
Mark Lawrence breamore...@yahoo.co.uk added the comment:
The patch looks clean to me although I don't feel qualified to comment on the
technical aspects. I've tested it on Windows Vista 32 bit against the 2.7 and
3.1 maintainance releases and py3k. The 2.7 run was fine, both 3.x runs failed.
Dave Malcolm dmalc...@redhat.com added the comment:
The 'u' prefix went away in Python 3, use an unadorned '' or for a unicode
value.
$ python3
Python 3.1.2 (r312:79147, May 25 2010, 12:21:57)
[GCC 4.4.3 20100422 (Red Hat 4.4.3-18)] on linux2
Type help, copyright, credits or license for more
Mark Lawrence breamore...@yahoo.co.uk added the comment:
I've successfully rerun the tests for 3.x having stripped the 'u' prefix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
Meador Inge mead...@gmail.com added the comment:
Attached a patch that provides a (sha | md5) - hashlib fixer, covering test
cases, and updated documentation.
--
keywords: +patch
nosy: +minge
Added file: http://bugs.python.org/file16079/issue-2454.patch
Changes by Brian Curtin cur...@acm.org:
--
components: -2to3 (2.x to 3.0 conversion tool)
stage: - patch review
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
Changes by Martin v. Löwis mar...@v.loewis.de:
--
components: +2to3 (2.x to 3.0 conversion tool)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
Changes by Daniel Diniz aja...@gmail.com:
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list
Changes by Armin Ronacher [EMAIL PROTECTED]:
--
nosy: +aronacher
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing
Changes by Collin Winter [EMAIL PROTECTED]:
--
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2454
__
___
Python-bugs-list mailing list
Changes by Benjamin Peterson [EMAIL PROTECTED]:
--
title: md5 fixer - sha and md5 fixer
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2454
__
___
Python-bugs-list
20 matches
Mail list logo