[issue24635] test_typing is flaky

Guido van Rossum added the comment: Sorry, this is a bug in typing.py. https://github.com/ambv/typehinting/issues/155 It's a subtle bug but the first reporter has done some good research; I will try to find time to fix it today. -- ___ Python

[issue24635] test_typing is flaky

STINNER Victor added the comment: > It's a subtle bug but the first reporter has done some good research; I will > try to find time to fix it today. Oh, it's already known and investigated by someone else. Great. I didn't know this github project. --

[issue24635] test_typing is flaky

Guido van Rossum added the comment: Assigning to Larry since the next step is his. -- assignee: gvanrossum -> larry priority: high -> release blocker ___ Python tracker

[issue24635] test_typing is flaky

Roundup Robot added the comment: New changeset d1f41c614e62 by Guido van Rossum in branch '3.5': Issue #24635: Fixed flakiness in test_typing.py. https://hg.python.org/cpython/rev/d1f41c614e62 -- nosy: +python-dev ___ Python tracker

[issue24635] test_typing is flaky

Guido van Rossum added the comment: BTW, I screwed up and committed this into the public 3.5 repo first (and merged from there into default). I guess once Larry has merged the fix into his special closed 3.5 bitbucket repo I should do a null merge from there back to public 3.5 and forward the

[issue24635] test_typing is flaky

Guido van Rossum added the comment: Fixed now on the 3.5 branch. I still have to merge to default and create the pull request for Larry. -- assignee: -> gvanrossum resolution: -> fixed ___ Python tracker

[issue24635] test_typing is flaky

Guido van Rossum added the comment: Pull request for Larry: https://bitbucket.org/larry/cpython350/pull-requests/14/fix-issue-24635/diff -- ___ Python tracker

[issue24635] test_typing is flaky

Larry Hastings added the comment: Pull request accepted. Please forward merge, thanks! And, yes, this will be a null merge because you already separately committed it to 3.5. -- assignee: larry -> gvanrossum stage: needs patch -> resolved status: open -> closed

[issue24635] test_typing is flaky

Guido van Rossum added the comment: OK, done. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24635] test_typing is flaky

Roundup Robot added the comment: New changeset 0f37918440c9 by Guido van Rossum in branch 'default': Issue #24635: Fixed flakiness in test_typing.py. (Merge from 3.5.) https://hg.python.org/cpython/rev/0f37918440c9 New changeset 438dde69871d by Guido van Rossum in branch '3.5': Fix issue

[issue24635] test_typing is flaky

STINNER Victor added the comment: Ok, I found a short script to reproduce the bug: -- import typing: assert isinstance([], typing.Container) assert isinstance([], typing.Container) -- The first check calls typing.GenericMeta.__subclasscheck__(list) which calls

[issue24635] test_typing is flaky

STINNER Victor added the comment: == FAIL: test_abstractset (test.test_typing.CollectionsAbcTests) -- Traceback (most recent call last): File

[issue24635] test_typing is flaky

STINNER Victor added the comment: > Anything happening with this? We tag 3.5.0rc3 in about 36 hours. I believe that it's a bug in test_typing, not in the typing module. So it must not block the release. -- ___ Python tracker

[issue24635] test_typing is flaky

Larry Hastings added the comment: Anything happening with this? We tag 3.5.0rc3 in about 36 hours. -- ___ Python tracker ___

[issue24635] test_typing is flaky

STINNER Victor added the comment: Is there any progress on this issue? It's still failing randomly: http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.5/builds/221/steps/test/logs/stdio -- ___ Python tracker

[issue24635] test_typing is flaky

Changes by Larry Hastings : -- priority: deferred blocker -> high ___ Python tracker ___

[issue24635] test_typing is flaky

Larry Hastings added the comment: Deferring for beta 4. We should still fix before release. Preferably before RC1 depending on the availability of Certain Persons. -- nosy: +larry priority: release blocker - deferred blocker ___ Python tracker

[issue24635] test_typing is flaky

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24635 ___ ___ Python-bugs-list

[issue24635] test_typing is flaky

Guido van Rossum added the comment: You can list me as the expert for typing.py, since I wrote it. :-) (However, until mid August I have limited availability since I'm on vacation.) This looks indeed like a test order dependency. The three failures are all basic failures where an empty set,

[issue24635] test_typing is flaky

Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- nosy: +lukasz.langa ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24635 ___ ___

[issue24635] test_typing is flaky

New submission from R. David Murray: See for example: http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Non-Debug%203.x/builds/106 It might be a test order dependency, but see http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/11931 where the test passed