[issue24656] remove "assret" from mock error checking

2015-07-19 Thread Nick Coghlan
Nick Coghlan added the comment: Marking as rejected by the module maintainer. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue24656] remove "assret" from mock error checking

2015-07-18 Thread Michael Foord
Michael Foord added the comment: -1 The whole thread is absurd. I'm travelling for europython and only have internet access on my phone until tomorrow at the earliest. On Saturday, 18 July 2015, Berker Peksag wrote: > > Changes by Berker Peksag : > > > -- > nosy: +kushal.das, ncoghlan,

[issue24656] remove "assret" from mock error checking

2015-07-18 Thread Ethan Furman
Ethan Furman added the comment: Addressed comments from berker.peksag. -- Added file: http://bugs.python.org/file39948/remove_assret.stoneleaf.03.patch ___ Python tracker ___ ___

[issue24656] remove "assret" from mock error checking

2015-07-18 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +kushal.das, ncoghlan, rbcollins ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue24656] remove "assret" from mock error checking

2015-07-18 Thread Ethan Furman
Changes by Ethan Furman : -- stage: -> patch review type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue24656] remove "assret" from mock error checking

2015-07-18 Thread Ethan Furman
Ethan Furman added the comment: Better patch: fixes NEWS, tests, and docs, as well as the code. -- Added file: http://bugs.python.org/file39945/remove_assret.stoneleaf.02.patch ___ Python tracker __

[issue24656] remove "assret" from mock error checking

2015-07-17 Thread Ethan Furman
New submission from Ethan Furman: Per Nick's suggestion here is the patch to remove the "assret" check, but leave the "assert" check in place. As Terry summarized: > 1. It is false that 'assret' is necessarily a typo. Someone might quite > legitimately use it as an attribute. Aside from the fac