[issue24740] make patchcheck doesn't detect changes if commit is done first

Terry J. Reedy added the comment: I am pretty sure I have done the same after making all commits to the local branch. Plus we have the better workflow. So closing until there is a confirmed problem with the new workflow. -- resolution: -> out of date stage: needs patch -> resolved

[issue24740] make patchcheck doesn't detect changes if commit is done first

Cheryl Sabella added the comment: I believe this issue has been resolved under the new Github workflow. I ran `make patchcheck` on a commit that had been pushed and it identified the changes. -- nosy: +cheryl.sabella ___ Python tracker

[issue24740] make patchcheck doesn't detect changes if commit is done first

R. David Murray added the comment: You can install the same (patchcheck-equivalent) hooks the repo uses in your local repo. If this is not documented in the devguide it should be. The hooks are publicly available (hg.python.org/hooks). (It has been so long since I set this up for myself tha

[issue24740] make patchcheck doesn't detect changes if commit is done first

Terry J. Reedy added the comment: Better: a local commit hook that rejects commits that cannot be pushed. I think this has been discussed, but never done, unless something has been added to the devguide that I missed. Better still: the hoped-for new workflow where patches are submitted to an

[issue24740] make patchcheck doesn't detect changes if commit is done first

New submission from Robert Collins: ./python ./Tools/scripts/patchcheck.py Getting the list of files that have been added/changed ... 0 files Fixing whitespace ... 0 files Fixing C file whitespace ... 0 files Fixing docs whitespace ... 0 files Docs modified ... NO Misc/ACKS updated ... NO Misc/NE