[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Karthikeyan Singaravelan added the comment: Closing this as resolved since PR was merged. Thanks Zackery for the PR. -- nosy: +xtreak resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Kushal Das added the comment: New changeset b9b08cd948de97d756a199b60becce8397a8c882 by Kushal Das (Zackery Spytz) in branch 'master': bpo-24758: Improve the error msg for unittest.mock.Mock()'s unsafe mode (#12991) https://github.com/python/cpython/commit/b9b08cd948de97d756a199b60becce8397a8

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Zackery Spytz added the comment: I've created a PR for this issue. -- nosy: +ZackerySpytz versions: +Python 3.8 -Python 3.5 ___ Python tracker ___

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Change by Zackery Spytz : -- keywords: +patch pull_requests: +12914 stage: needs patch -> patch review ___ Python tracker ___ ___ Py

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Robert Collins added the comment: @Randy - ok thanks. So, please do improve the prose in the error message, should be a very straight forward patch. -- stage: test needed -> needs patch ___ Python tracker

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Randy Syring added the comment: Old functionality: (temp)rsyring@loftex:~/projects/hllapi-src$ python Python 2.7.6 (default, Jun 22 2015, 17:58:13) [GCC 4.8.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import mock >>> mock.__version__ '1.0.0' >>> m = m

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Robert Collins added the comment: How were you setting/introducing your assertions on the mocks? e.g. could you supply a small sample script showing what used to work? Thanks. -- nosy: +rbcollins ___ Python tracker

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Changes by Robert Collins : -- stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

Changes by Dima Tisnek : -- nosy: +Dima.Tisnek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue24758] unittest.mock.Mock's new "unsafe" feature needs a better error message

New submission from Randy Syring: In issue http://bugs.python.org/issue21238 a feature was introduced to help prevent false-positive test cases by throwing an AttributeError whenever a non-existent method prefixed with "assert_" is used on a mock object. I had mock objects with legitimate "ass