[issue2489] Patch for bugs in pty.py

Antoine Pitrou added the comment: The test breaks on OpenIndiana (and possibly elsewhere): http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.x/builds/4640 == FAIL: test_spawn_returns_status (test.test_pty.PtyTest) --

[issue2489] Patch for bugs in pty.py

Changes by Gregory P. Smith : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2489] Patch for bugs in pty.py

Roundup Robot added the comment: New changeset ec2921d4de37 by Gregory P. Smith in branch 'default': pty.spawn() now returns the child process status as returned by os.waitpid(). http://hg.python.org/cpython/rev/ec2921d4de37 -- ___ Python tracker

[issue2489] Patch for bugs in pty.py

Gregory P. Smith added the comment: I'm keeping this open to address the added behavior for spawn in 3.3. -- assignee: -> gregory.p.smith nosy: +gregory.p.smith stage: test needed -> versions: +Python 3.3 -Python 2.7, Python 3.1, Python 3.2 ___ Pyt

[issue2489] Patch for bugs in pty.py

Roundup Robot added the comment: New changeset 994659efa292 by Gregory P. Smith in branch '3.2': Issue #2489: Fix bug in _copy loop that could consume 100% cpu on EOF. http://hg.python.org/cpython/rev/994659efa292 New changeset c7338f62f956 by Gregory P. Smith in branch 'default': Issue #2489:

[issue2489] Patch for bugs in pty.py

R. David Murray added the comment: OK, file restored. Design bugs are usually fixed by "feature requests" :) See issue 967171 for the feature request. -- versions: +Python 2.7, Python 3.2 -Python 2.4, Python 2.6 ___ Python tracker

[issue2489] Patch for bugs in pty.py

Changes by R. David Murray : Added file: http://bugs.python.org/file18666/pty.py.patch3 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue2489] Patch for bugs in pty.py

R. David Murray added the comment: That didn't work so well :( -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue2489] Patch for bugs in pty.py

Changes by R. David Murray : Removed file: http://bugs.python.org/file18665/pty.py.patch3 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue2489] Patch for bugs in pty.py

R. David Murray added the comment: Woops, didn't mean to delete that file. Reattaching. -- nosy: +r.david.murray Added file: http://bugs.python.org/file18665/pty.py.patch3 ___ Python tracker __

[issue2489] Patch for bugs in pty.py

Changes by R. David Murray : Removed file: http://bugs.python.org/file14148/pty.py.patch3 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue2489] Patch for bugs in pty.py

Changes by Fergus Henderson : Added file: http://bugs.python.org/file14149/pty.py.patch2 ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue2489] Patch for bugs in pty.py

Fergus Henderson added the comment: The spawn change (the last hunk of the original patch) is a bug fix, not an RFE. It has two parts that fix two bugs: (1) a coding bug: spawn() would not wait for the invoked process to finish. This is fixed by the line that adds the call to os.waitpid().

[issue2489] Patch for bugs in pty.py

Changes by Petr Splichal : -- nosy: +psss ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue2489] Patch for bugs in pty.py

Daniel Diniz added the comment: Fergus, Can you provide a test for the _copy loop bug? IIUC, the spawn change is an RFE and shouldn't land on the maintenance branches (or 3.1). -- nosy: +ajaksu2 priority: -> normal stage: -> test needed versions: +Python 3.1 -Python 2.5, Python 3.0 _

[issue2489] Patch for bugs in pty.py

Fergus Henderson <[EMAIL PROTECTED]> added the comment: On Tue, Mar 25, 2008 at 9:22 PM, Guilherme Polo <[EMAIL PROTECTED]> wrote: > > I would suggest using "if not data" to check for EOF Good idea. __ Tracker <[EMAIL PROTECTED]>

[issue2489] Patch for bugs in pty.py

Guilherme Polo <[EMAIL PROTECTED]> added the comment: Hi Fergus, I would suggest using "if not data" to check for EOF -- nosy: +gpolo __ Tracker <[EMAIL PROTECTED]> __ ___

[issue2489] Patch for bugs in pty.py

New submission from Fergus Henderson <[EMAIL PROTECTED]>: The attached patch fixes some bugs in the pty.py module: - spawn() would not wait for the invoked process to finish. Also, it did not return a meaningful value, so there was no way to tell if the invoked process failed.After