[issue24937] Multiple problems in getters & setters in capsulethunk.h

Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Petr Viktorin added the comment: New changeset 2d3ff2b5ea6c903973f99d2155c9c1b60591dceb by Petr Viktorin in branch 'master': bpo-24937: Replace the extension module porting HOWTO by links to external projects (GH-9317)

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Change by Petr Viktorin : -- pull_requests: +8743 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Petr Viktorin added the comment: Well, hasn't this languished for a while. I've talked with Benjamin, and he's OK with just removing the "Porting Extension Modules to Python 3" HOWTO, and replacing it by links to external guides that do a much better job at documenting this. Also, Python

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Berker Peksag added the comment: It would be nice to remove PyCObject_* entries from Doc/data/refcounts.dat. +.. _documentation: http://py3c.readthedocs.org/en/latest/capsulethunk.html Nit: We could the HTTPS link. -- nosy: +berker.peksag stage: -> patch review type: ->

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Larry Hastings added the comment: I'm the author of capsulethunk.h, and I am happy to relicense it under MIT. How would you feel about leaving capsulethunk.h there, for posterity's sakes, but adding "for updates please see py3c"? We could even update the capsulethunk.h there. I'm not saying

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Petr Viktorin added the comment: This patch removes capsulethunk.h from the docs, and directs the kind reader to the py3c project, which carries a fixed and tested version of it, along with the docs. Larry, would you be OK with releasing capsulethunk.h under the MIT license? The PSF license

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Petr Viktorin added the comment: Thank you for the license. I mentioned my project mainly as a place where this code can be *tested*. I have no problem with keeping capsulethunk.h in the Python docs, and synchronizing the two projects if changes are made on either side. In other words, feel

[issue24937] Multiple problems in getters setters in capsulethunk.h

Larry Hastings added the comment: Given that capsulethunk is only needed for 2.6 (and previous), and those versions are no longer maintained by the Python core community, yes I'd be happy for you to take over maintainership and host it externally. I'm sure we could change the documentation

[issue24937] Multiple problems in getters setters in capsulethunk.h

Petr Viktorin added the comment: Note: I'm including a tested (+fixed, now) copy of capsulethunk.h in my set of Python3 C extension porting helpers, http://py3c.readthedocs.org Unfortunately the tests can't be added to CPython, because they need to run on Python 2.6 to be useful. That makes

[issue24937] Multiple problems in getters setters in capsulethunk.h

New submission from Petr Viktorin: In https://docs.python.org/3/howto/cporting.html#cobject-replaced-with-capsule (added in issue13053): 1) __PyCapsule_GetField is defined as:: #define __PyCapsule_GetField(capsule, field, default_value) ... but called as::