[issue2501] xml.sax.parser() doesn't terminate when given a filename

Changes by Nick Coghlan : -- Removed message: http://bugs.python.org/msg168983 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Roundup Robot added the comment: New changeset 3a831a0a29c4 by Nick Coghlan in branch 'default': Close #2501: Permission bits are once again correctly copied from the source file to the cached bytecode file. Test by Eric Snow. http://hg.python.org/cpython/rev/3a831a0a29c4 -- nosy: +pyth

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Applied in r66203. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: Benjamin will commit this. -- assignee: -> benjamin.peterson nosy: +barry resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED]> __

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Daniel Diniz <[EMAIL PROTECTED]> added the comment: Looks like this is a duplicate of issue3590, so this patch fixes two release blockers ;) ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The patch looks great. (I love enabling disabled tests!) -- keywords: -needs review nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> __

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Christian Heimes <[EMAIL PROTECTED]> added the comment: I've a better idea: while buffer: It's faster and works for both empty bytes and str. The patch fixes the issue and re-enables three unit tests. -- keywords: +needs review, patch Added file: http://bugs.python.org/file11295

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Daniel Diniz <[EMAIL PROTECTED]> added the comment: ISTM that this release blocker can be solved by changing xml.sax.xmlreader.py line 122 from: while buffer != "": to while buffer != b"": -- nosy: +ajaksu2 ___ Python tracker <[EMAIL P

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue2501] xml.sax.parser() doesn't terminate when given a filename

Christian Heimes <[EMAIL PROTECTED]> added the comment: I had to disable three unit tests in test_sax. We didn't noticed the problem before because the tests weren't actually run. The three tests are marked clearly with XXX and FIXME. -- nosy: +tiran priority: -> critical _

[issue2501] xml.sax.parser() doesn't terminate when given a filename

New submission from Mark Summerfield <[EMAIL PROTECTED]>: The tiny program at the end of this message runs under Python 2.5 & 30a3. Under 2 it gives the following output: : python sax.py test.xml ('+', u'document') ('+', u'outer') ('+', u'inner') ('-', u'inner') ('-', u'outer') ('-', u'document'