[issue25139] socketserver.ThreadingMixIn exception handler: Just a little refactoring

2016-02-21 Thread Martin Panter
Martin Panter added the comment: I pushed the above code to 3.6, so closing this. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed superseder: -> socketserver.BaseServer.handle_error() should not catch exiting exceptions

[issue25139] socketserver.ThreadingMixIn exception handler: Just a little refactoring

2015-09-19 Thread Martin Panter
Martin Panter added the comment: I suggest changing the “except” clause to “except BaseException”, which would make the intention clearer. As an alternative, see also my Issue 23430, were I proposed not catching exceptions like KeyboardInterrupt and SystemExit, by changing this to: try: