[issue25245] Compile warnings in _pickle.c

Benjamin Peterson added the comment: Why not just initially set *s to NULL in _Unpickler_Read? -- ___ Python tracker ___

[issue25245] Compile warnings in _pickle.c

Serhiy Storchaka added the comment: > Why not just initially set *s to NULL in _Unpickler_Read? It would be the third variant. The fourth variant is to change the signature of _Unpickler_Read() and return char * (NULL on error). All these variants work, I examined them. --

[issue25245] Compile warnings in _pickle.c

Benjamin Peterson added the comment: Okay, I think it might make more sense for |s| to be a return value, but that change probably isn't appropriate for bugfix releases. -- ___ Python tracker

[issue25245] Compile warnings in _pickle.c

Roundup Robot added the comment: New changeset f0dcf7599517 by Benjamin Peterson in branch '3.4': initialize return value to NULL to avoid compiler compliants (closes #25245) https://hg.python.org/cpython/rev/f0dcf7599517 New changeset ef3b833b98c2 by Benjamin Peterson in branch '3.5': merge

[issue25245] Compile warnings in _pickle.c

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file40593/issue25245_2.patch ___ Python tracker ___

[issue25245] Compile warnings in _pickle.c

Serhiy Storchaka added the comment: Here are two alternative solutions. -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file40592/issue25245_1.patch ___ Python tracker

[issue25245] Compile warnings in _pickle.c

New submission from Serhiy Storchaka: Changeset 88d98f6c2d7d causes compile warnings in Modules/_pickle.c. /home/serhiy/py/cpython/Modules/_pickle.c: In function ‘load_counted_long’: /home/serhiy/py/cpython/Modules/_pickle.c:4752:15: warning: ‘pdata’ may be used uninitialized in this function