[issue2534] Restore isinstance and issubclass speed in 2.6

Change by STINNER Victor : -- nosy: +barry nosy_count: 8.0 -> 9.0 pull_requests: +17718 pull_request: https://github.com/python/cpython/pull/18345 ___ Python tracker ___ ___

[issue2534] Restore isinstance and issubclass speed in 2.6

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66042 and r66043. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2534] Restore isinstance and issubclass speed in 2.6

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Both patches look correct to me, and I think they can be applied. -- assignee: -> pitrou resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED]> _

[issue2534] Restore isinstance and issubclass speed in 2.6

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: +1 on applying this patch right away. For 2.6 and 3.0 to be successful, we need people to prefer to upgrade rather than stay with 2.5. A systemic slowdown in not in the best interests of the language moving forward. -- nosy: +r

[issue2534] Restore isinstance and issubclass speed in 2.6

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is the same patch, but backported to 2.6. Added file: http://bugs.python.org/file11261/isinstance26-2.patch ___ Python tracker <[EMAIL PROTECTED]> __

[issue2534] Restore isinstance and issubclass speed in 2.6

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: New patch with a couple of tiny fixes. Added file: http://bugs.python.org/file11257/isinstance3k-2.patch ___ Python tracker <[EMAIL PROTECTED]> __

[issue2534] Restore isinstance and issubclass speed in 2.6

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, here is the patch for py3k. As I said it fixes some interesting bugs (when the second argument was a tuple, isinstance() and issubclass() were trying to get __instancecheck__ / __subclasscheck__ on the tuple rather than on each of the tupl

[issue2534] Restore isinstance and issubclass speed in 2.6

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I'm currently doing the port to py3k. It makes me find interesting flaws in the current isinstance/issubclass implementation :-)) ___ Python tracker <[EMAIL PROTECTED]> __

[issue2534] Restore isinstance and issubclass speed in 2.6

Changes by djc <[EMAIL PROTECTED]>: -- nosy: +djc ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing list Unsubscri

[issue2534] Restore isinstance and issubclass speed in 2.6

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-

[issue2534] Restore isinstance and issubclass speed in 2.6

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- versions: +Python 3.0 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list

[issue2534] Restore isinstance and issubclass speed in 2.6

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: By the way, py3k suffers from this problem too, so a similar patch should be applied if possible. -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]>

[issue2534] Restore isinstance and issubclass speed in 2.6

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue2534] Restore isinstance and issubclass speed in 2.6

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Can this patch go in? -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue2534] Restore isinstance and issubclass speed in 2.6

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: speedup of this patch confirmed. Also, it triggers the bugs mentioned that have their own issues open. Once #2542 is fixed this should be looked at again. Its a big performance regression in 2.6 over 2.5 if we don't get this in, marking i