[issue25347] assert_has_calls output is formatted inconsistently

2016-01-12 Thread Senthil Kumaran
Senthil Kumaran added the comment: Verified the change and committed. The new output behavior will be like this. ``` >>> from unittest.mock import Mock >>> mock = Mock(return_value=None) >>> for i in range(1, 10): ... mock(i) ... >>> from unittest.mock import call >>> calls = [call(i) for i

[issue25347] assert_has_calls output is formatted inconsistently

2016-01-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 77d24f51effc by Senthil Kumaran in branch 'default': Issue25347 - Format the error message output of mock's assert_has_calls method. https://hg.python.org/cpython/rev/77d24f51effc -- nosy: +python-dev ___

[issue25347] assert_has_calls output is formatted inconsistently

2016-01-12 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch looks good to me. The change is in the error message of the AssertionError and don't test the error messages of Exceptions in our unittest. This change is a good usability improvement and I will commit this patch. -- assignee: -> orsenthil

[issue25347] assert_has_calls output is formatted inconsistently

2016-01-03 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue25347] assert_has_calls output is formatted inconsistently

2015-10-09 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker ___ ___ Pytho

[issue25347] assert_has_calls output is formatted inconsistently

2015-10-08 Thread Robert Zimmerman
New submission from Robert Zimmerman: For longer lists of calls, the "Expected" list is printed all on one line while the "Actual" list is pprinted and on multiple lines. This makes it hard to do a visual compare of which calls are missing/incorrect. Example: AssertionError: Calls not fou