[issue25351] pyvenv activate script failure with specific bash option

2017-09-29 Thread STINNER Victor
STINNER Victor added the comment: The bug has been fixed in Python 3.6 and 3.7 (master), thank you Sorin Sbarnea! Python 3.4 and 3.5 don't accept bug fixes anymore, only security fixes: https://devguide.python.org/#status-of-python-branches -- resolution: -> fixed stage: patch review

[issue25351] pyvenv activate script failure with specific bash option

2017-09-29 Thread STINNER Victor
STINNER Victor added the comment: New changeset a5610e07460a8df4b0923a32d37234cd535ec952 by Victor Stinner (Miss Islington (bot)) in branch '3.6': [3.6] bpo-25351: avoid activate failure on strict shells (GH-3804) (#3820) https://github.com/python/cpython/commit/a5610e07460a8df4b0923a32d37234c

[issue25351] pyvenv activate script failure with specific bash option

2017-09-29 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +3804 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue25351] pyvenv activate script failure with specific bash option

2017-09-29 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 90f1d989594f3340c5ffaa2cf9cef1876ac6bb89 by Vinay Sajip (Sorin Sbarnea) in branch 'master': bpo-25351: avoid activate failure on strict shells (GH-3804) https://github.com/python/cpython/commit/90f1d989594f3340c5ffaa2cf9cef1876ac6bb89 --

[issue25351] pyvenv activate script failure with specific bash option

2017-09-28 Thread Sorin Sbarnea
Sorin Sbarnea added the comment: Based on my tests this worked with all shells I tested with, the syntax being a very old one and not some new/modern one. Passed: bash, zsh, dash, ksh Platforms: MacOS, RHEL Linux Failed with: tcsh but with the note that even the original code would fail with

[issue25351] pyvenv activate script failure with specific bash option

2017-09-28 Thread R. David Murray
R. David Murray added the comment: Note that in the equivalent issue raised against virtualenv, the concern was raised that some old sh-like shells might not support this syntax, but it was pointed out that it is part of the posix standard. I'm not arguing for or against here, just noting re

[issue25351] pyvenv activate script failure with specific bash option

2017-09-28 Thread sorin
sorin added the comment: This is a perfectly valid bug and I am surprised it was ignored for so long. I just raised a PR for addressing it, please review it. -- keywords: +patch nosy: +sorin pull_requests: +3790 stage: -> patch review type: enhancement -> behavior versions: +Python 3

[issue25351] pyvenv activate script failure with specific bash option

2016-02-14 Thread Vinay Sajip
Vinay Sajip added the comment: Can you try the attached script in place of the current activate script and see if it meets the requirements? -- Added file: http://bugs.python.org/file41925/activate ___ Python tracker

[issue25351] pyvenv activate script failure with specific bash option

2016-02-06 Thread Ned Deily
Changes by Ned Deily : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue25351] pyvenv activate script failure with specific bash option

2015-10-09 Thread s-wakaba
New submission from s-wakaba: When writing bash shellscripts, I always set options "set -ueC" for strict error checking. However, loading pyvenv's activate and deactivate scripts from bash with "-u" option, they are failure because they may refer undefined shell variables. I hope activate scr