[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

Miko Ohtamaa added the comment: I think there is something more in this. I am running Python 3.5.0 (default, Apr 24 2016, 12:47:36). Sparkpost servers require AUTH LOGIN approach as per their instructions https://support.sparkpost.com/customer/portal/articles/1988470-smtp-connection-problems

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

Roundup Robot added the comment: New changeset d13263ecf0c6 by R David Murray in branch '3.5': #25446: Fix regression in smtplib's AUTH LOGIN support. https://hg.python.org/cpython/rev/d13263ecf0c6 New changeset 7368b86432c6 by R David Murray in branch 'default': Merge: #25446: Fix regression

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

R. David Murray added the comment: Fixed. I figured it was better not to wait for a review in this case...the fix is straightforward, but writing the test took quite a bit of work. The auth tests in smtplib are now much more robust, thanks in large part to Milan's code in issue 21935.

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

Larry Hastings added the comment: Okay, I'm scheduling 3.5.1rc1 on the assumption that you'll check in by next weekend. If you're going to slip please let me know and I'll slip accordingly. -- ___ Python tracker

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

Larry Hastings added the comment: I think it's about time to think about releasing 3.5.1. But since this bug is marked as a "release blocker", 3.5.1 cannot be released until this is fixed. Arguably I can't even really make a schedule for 3.5.1 until it's fixed, or at least I'm reasonably

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

R. David Murray added the comment: I will work on it this week, should have something committed before the end of next weekend. -- ___ Python tracker

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

Changes by Chris Angelico : -- nosy: +Rosuav ___ Python tracker ___ ___ Python-bugs-list

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

R. David Murray added the comment: Thanks, but special-casing login in the 'auth' method means that the auth method isn't working right, since special-casing defeats the whole purpose of the auth mechanism. I think we need to change the logic in auth so that it is checking for a 334 even if

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

R. David Murray added the comment: Can you explain more about the failure you are seeing? -- ___ Python tracker ___

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

R. David Murray added the comment: Sorry, I misremenbered and thought that fix didn't make it in to 3.5, but in fact you are talking about the behavior of that fix. -- ___ Python tracker

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

R. David Murray added the comment: Does the fix at the end of issue 15014 address your concern? -- ___ Python tracker ___

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

New submission from Oliver Merkel: class SMTP: def auth_login(self, challenge=None): The self.docmd should use cmd "AUTH" with parameter "LOGIN" + encoded login like (code, resp) = self.docmd("AUTH", "LOGIN " + encode_base64(self.user.encode('ascii'), eol='')) with

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

Oliver Merkel added the comment: Sample session log output showing the error with smtp.set_debuglevel(1): send: 'ehlo \r\n' reply: b'250- Hello [myIP4address]\r\n' reply: b'250-SIZE 53248000\r\n' reply: b'250-PIPELINING\r\n' reply: b'250-DSN\r\n' reply: b'250-ENHANCEDSTATUSCODES\r\n' reply:

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

Oliver Merkel added the comment: Let us assume you want to establish a smtp session with AUTH LOGIN as the supported authentication type. Sample code to send mail: Typical preparation steps like with SMTP( mailserver, 587 ) as smtp: # smtp.set_debuglevel(1) smtp.ehlo()

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

R. David Murray added the comment: Ah, now I see what you are saying. How in the world did we miss that? Our unit tests must be broken too. -- keywords: +3.5regression priority: normal -> release blocker stage: -> needs patch versions: +Python 3.6

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

Oliver Merkel added the comment: Change proposal attached as a unified diff / patch file. -- keywords: +patch Added file: http://bugs.python.org/file40829/smtplib-patch.issue25446.patch ___ Python tracker