[issue25523] Correct "a" article to "an" article

2016-07-11 Thread Martin Panter
Changes by Martin Panter : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue25523] Correct "a" article to "an" article

2016-07-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 651f7addf4a8 by Martin Panter in branch '2.7': Issue #25523: Correct "a" article to "an" article https://hg.python.org/cpython/rev/651f7addf4a8 -- ___ Python tracker _

[issue25523] Correct "a" article to "an" article

2015-11-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Martin for your review. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue25523] Correct "a" article to "an" article

2015-11-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 75df8b0a2cd1 by Serhiy Storchaka in branch '3.4': Issue #25523: Further a-to-an corrections. https://hg.python.org/cpython/rev/75df8b0a2cd1 New changeset 68edc7baeef7 by Serhiy Storchaka in branch '3.5': Issue #25523: Merge a-to-an corrections from

[issue25523] Correct "a" article to "an" article

2015-11-02 Thread Martin Panter
Martin Panter added the comment: Thanks Serhiy. My pass over the files missed most cases where there was a line break involved, and certain punctuation and markup, which you picked up on. I skipped the /Lib/msilib/schema.py file in my patch because it was part of the data rather than a comment

[issue25523] Correct "a" article to "an" article

2015-11-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch with additional changes. -- resolution: fixed -> stage: resolved -> patch review status: closed -> open Added file: http://bugs.python.org/file40925/a-an_2.patch ___ Python tracker

[issue25523] Correct "a" article to "an" article

2015-11-01 Thread Martin Panter
Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue25523] Correct "a" article to "an" article

2015-11-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset d8ff13414deb by Martin Panter in branch '3.4': Issue #25523: Correct "a" article to "an" article https://hg.python.org/cpython/rev/d8ff13414deb New changeset e279ab6753fd by Martin Panter in branch '3.5': Issue #25523: Merge "a" to "an" fixes from 3

[issue25523] Correct "a" article to "an" article

2015-11-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I had pointed to some of changes not because they look wrong to me, but for the case if there are human mistakes. After your acknowledgement all LGTM. -- stage: patch review -> commit review ___ Python tracker

[issue25523] Correct "a" article to "an" article

2015-11-01 Thread Martin Panter
Martin Panter added the comment: Thanks everyone for the comments. Serhiy’s points: I did this by using “grep” and then manually editing all of the appropriate lines. So they were not generated by a script, but because it is a fairly mindless process I could have made human mistakes. In multi

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread Mark Dickinson
Mark Dickinson added the comment: Yes, the Lib/test/decimaltestdata files do come from an external source. I don't see the harm in including them in the changes, but those changes will be overwritten when the files are next updated. -- ___ Python tr

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread Mark Dickinson
Mark Dickinson added the comment: I should have said what that source is: it's http://speleotrove.com/decimal/ -- ___ Python tracker ___ _

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread R. David Murray
Changes by R. David Murray : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread R. David Murray
R. David Murray added the comment: Yes, those deletions are intentional, they make the English read better (to me as a native speaker, at least :) As Emanuel said, the SMTP thing comes from reading it as an acronym, which is how I generally do it, and I suppose most people do. Given how thor

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread Emanuel Barry
Emanuel Barry added the comment: > In Doc/library/smtplib.rst "a" is replaced to "an" before a word starting > with consonant: SMTP. Is it correct? One of the peculiriarities of the English language is that, in front of acronyms, you have two different ways to decided which to use between "a"

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I suppose that changes was generated by a script. But some changes looks not satisfying a simple rule. In Doc/library/multiprocessing.rst, Doc/library/socket.rst, Doc/whatsnew/3.2.rst, Misc/HISTORY, Modules/_hashopenssl.c "a" is just deleted. Is it delibera

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread Martin Panter
Martin Panter added the comment: Rebased so it should be reviewable -- Added file: http://bugs.python.org/file40910/a-an.patch ___ Python tracker ___

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread Martin Panter
Changes by Martin Panter : Removed file: http://bugs.python.org/file40909/a-an.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue25523] Correct "a" article to "an" article

2015-10-31 Thread Martin Panter
New submission from Martin Panter: This patch generally changes “a” to “an” where appropriate in the main documentation, doc strings, source code comments, and a couple error messages in the test suite. Since it touches so many files, I thought it would be good to get a quick review.