[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Karthikeyan Singaravelan added the comment: I guess the inconsistency in original report is fixed with issue28703 where both inspect.iscoroutinefunction and asyncio.iscoroutinefunction return False for Mock(). The fix is available from 3.5.3 . There is also async support for mock added in

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Guido van Rossum added the comment: No I just misremembered. --Guido (mobile) -- ___ Python tracker ___ ___

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Yury Selivanov added the comment: > Now we missed the 3.5.2 deadline. Did you mean 3.5.1? Or Larry is going to rush 3.5.2 soon? -- ___ Python tracker

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Joseph Gordon added the comment: I uploaded a patch that appears to fix the issue. -- keywords: +patch Added file: http://bugs.python.org/file41396/issue25599.patch ___ Python tracker

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Guido van Rossum added the comment: Oh dang. We were waiting for the OP to submit a patch (not very complex) but they never did. Now we missed the 3.5.2 deadline. Maybe someone can try again for 3.5.3? On Tue, Dec 22, 2015 at 12:30 AM, Joseph Gordon wrote: > > Changes

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Guido van Rossum added the comment: OK, I concede your point. It shouldn't be too hard to make asyncio.iscoroutinefunction() behave the same way as inspect.iscoroutinefunction(). Can you submit a patch? -- ___ Python tracker

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Theron Luhn added the comment: For me, the context is a test I was writing that went something like this: >>> import asyncio >>> from unittest.mock import Mock >>> loop = asyncio.get_event_loop() >>> blocking_func = Mock() >>> loop.run_in_executor(None, blocking_func) Traceback (most recent

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Guido van Rossum added the comment: Hm... I don't know what answer you would expect. Who says your mock shouldn't behave like a coroutine? In general, passing mocks to functions is likely to return a mock -- even boolean functions. Can you provide more context? --

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

New submission from Theron Luhn: >>> asyncio.iscoroutinefunction(unittest.mock.Mock()) This is an unexpected response, both in type (Mock rather than boolean) and value (truthy). inspect.iscoroutinefunction behaves as expected. Workaround: >>> m = unittest.mock.Mock() >>> m._is_coroutine =

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

STINNER Victor added the comment: >>> asyncio.iscoroutinefunction(unittest.mock.Mock()) Yeah, I already had this issue when I wrote unit tests using mock :-/ I didn't find an obvious fix for this issue, and it's quite easy to workaround it. It looks like the "m._is_coroutine = False" is not