[issue25670] ast.NodeTransformer: remove duplicate getattr()

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue25670] ast.NodeTransformer: remove duplicate getattr()

Serhiy Storchaka added the comment: LGTM! -- assignee: -> haypo components: +Library (Lib) nosy: +serhiy.storchaka stage: -> commit review ___ Python tracker

[issue25670] ast.NodeTransformer: remove duplicate getattr()

New submission from STINNER Victor: ast.NodeTransformer.generic_visit() calls getattr() whereas iter_fields() already returns the attribute. The getattr() is useless, attached patch removes it. Sadly, it looks like test_ast doesn't test this class at all :-( The class is tested *indirectly*

[issue25670] ast.NodeTransformer: remove duplicate getattr()

STINNER Victor added the comment: Oh, the getattr() is as old as the Lib/ast.py module: change 7d824fd131ad. -- ___ Python tracker ___

[issue25670] ast.NodeTransformer: remove duplicate getattr()

Roundup Robot added the comment: New changeset 7789f338447f by Victor Stinner in branch '3.5': Issue #25670: Remove duplicate getattr() from ast.NodeTransformer https://hg.python.org/cpython/rev/7789f338447f New changeset 2d90f4b27743 by Victor Stinner in branch 'default': Merge 3.5 (issue