[issue25757] Subclasses of property lose docstring

Berker Peksag added the comment: Thanks for the patch, Torsten. This is a duplicate of issue 24766. Your patch is almost identical (except the behavior change) to the patch in issue 24766. I will adapt your test and attribute your name in commit message. -- resolution: -> duplicate

[issue25757] Subclasses of property lose docstring

Roundup Robot added the comment: New changeset cc1aa0e88626 by Berker Peksag in branch '3.5': Issue #25755: Move PropertyWritableDoc into the test case https://hg.python.org/cpython/rev/cc1aa0e88626 New changeset 8f52c9d72d9f by Berker Peksag in branch 'default': Issue #25755: Move

[issue25757] Subclasses of property lose docstring

Berker Peksag added the comment: fix_repetitions.diff was unrelated to this issue so subprop_doc_r2.diff still needs to be reviewed. -- ___ Python tracker

[issue25757] Subclasses of property lose docstring

Berker Peksag added the comment: Thanks for fix_repetitions.diff, Torsten. The test_property failure was discussed in issue 25755. -- nosy: +berker.peksag ___ Python tracker

[issue25757] Subclasses of property lose docstring

Raymond Hettinger added the comment: Can this be closed now or is there work left to be done? -- nosy: +rhettinger ___ Python tracker ___

[issue25757] Subclasses of property lose docstring

Torsten Landschoff added the comment: Prompted by Emanuel's comment I ran the test with repetitions. This does not actually test his assertion that I missed a decref since he referred to the error case when setting the __doc__ key of the instance dict fails. But I was curious none the less.

[issue25757] Subclasses of property lose docstring

Emanuel Barry added the comment: Looking at it again, it appears you didn't have to decref it; my bad. Both patches LGTM. -- ___ Python tracker ___

[issue25757] Subclasses of property lose docstring

Changes by Torsten Landschoff : Added file: http://bugs.python.org/file41181/subprop_doc_r2.diff ___ Python tracker ___

[issue25757] Subclasses of property lose docstring

Emanuel Barry added the comment: Pointed out a refleak and a small nit. -- nosy: +ebarry stage: -> patch review ___ Python tracker ___

[issue25757] Subclasses of property lose docstring

New submission from Torsten Landschoff: I actually found this in Python2, but it is still unchanged in Python 3.6 dev. Namely, creating an instance of a class derived from property will drop the docstring passed explicitly to the constructor: torsten@defiant:~$ python3.6 Python 3.6.0a0

[issue25757] Subclasses of property lose docstring

Torsten Landschoff added the comment: Just a note about the patch: I changed the behaviour a bit in that the code does not ignore random exceptions while getting getter.__doc__. I think that would be surprising for most users and it also does not match the application of the doc field to the

[issue25757] Subclasses of property lose docstring

Torsten Landschoff added the comment: Here is a proposed patch to correct this including regression tests. -- keywords: +patch Added file: http://bugs.python.org/file41176/subprop_doc.diff ___ Python tracker