[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Pablo Galindo Salgado added the comment: New changeset 97e0de04b8cd44474e452a028761e34407192041 by Zackery Spytz in branch 'master': bpo-25780: Expose CAN_RAW_JOIN_FILTERS in the socket module (GH-19190) https://github.com/python/cpython/commit/97e0de04b8cd44474e452a028761e34407192041

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Change by Zackery Spytz : -- nosy: +ZackerySpytz nosy_count: 3.0 -> 4.0 pull_requests: +18550 pull_request: https://github.com/python/cpython/pull/19190 ___ Python tracker ___

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

New submission from Stefan Tatschner: Here is a patch, which adds support for CAN_RAW_JOIN_FILTERS which is available since linux 4.1 [1]. My patch fixes trailing whitespace issues as well. Since I have a newer version of autotools, running "autoreconf" generates a lot of changes, so I left

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Stefan Tatschner added the comment: in case you don't like whitespace cleanups, here is the patch with "git diff --ignore-space-changes". -- Added file: http://bugs.python.org/file41211/can_raw_join_filters-no-whitespace.diff ___ Python tracker

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Martin Panter added the comment: Not sure what the general policy is, but IMO it is better to leave offensive white space as it is to avoid flooding the file history and diffs, unless you are editing nearby lines. I will leave some review comments for the documentation. -- nosy:

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Stefan Tatschner added the comment: Hmm. I just adapted this feature request from issue22631 for the new constant and I verified that my patch actually works. I could try to provide a test, but then I would have to open Pandora's box as I am not a CPython developer at all. :/ --

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

R. David Murray added the comment: In this particular case, whether we want to do that to config.ac is a separate question and should be addressed in a separate issue. -- nosy: +r.david.murray ___ Python tracker

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Stefan Tatschner added the comment: Thanks! Here is an update. -- Added file: http://bugs.python.org/file41218/can_raw_join_filters-no-whitespace-v2.diff ___ Python tracker

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

R. David Murray added the comment: Yes. The review system will automatically include the new patch, regardless of its name (it looks at the content). -- ___ Python tracker

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Martin Panter added the comment: The other thing for new features is test cases. I don’t know if there are any existing CAN socket tests (in fact I don’t know anything about CAN sockets). Is it possible to make a test for this? Even if it just ensures that the setting can be applied when

[issue25780] Add support for CAN_RAW_JOIN_FILTERS

Stefan Tatschner added the comment: Because is the first time I work with this bugtracking system on python.org, how can I update my patch? :) Just upload a new one? -- ___ Python tracker