[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Changes by Donald Stufft : -- pull_requests: +883 ___ Python tracker ___ ___

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Berker Peksag added the comment: Thank you Gergely and Markus! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Roundup Robot added the comment: New changeset a5e8fe666c6b by Berker Peksag in branch '3.5': Issue #25895: Enable WebSocket URL schemes in urllib.parse.urljoin https://hg.python.org/cpython/rev/a5e8fe666c6b New changeset 9bf370a33938 by Berker Peksag in branch '3.6': Issue #25895: Merge from

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Markus Holtermann added the comment: Thanks for your input. I remove the versionchanged block. -- Added file: http://bugs.python.org/file44649/0001-Enable-WebSocket-URL-schemes-in-urllib.parse.urljoin.patch ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

R. David Murray added the comment: I believe our stance on these has changed over time from "feature" to "bugfix", especially when there is a standards document to back it (but sometimes when there is not...we gave up a while ago on the MIME-type standards ever getting finalized and just bow

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Martin Panter added the comment: IMO if a versionadded/versionchanged notice is relevant, that is a good sign it is a feature rather than bug fix. If the 3.6.1 documentation says “added in 3.5.3”, how do you know if it is in 3.6.0? I looked at the history of other schemes being added to try

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Robert Collins added the comment: I find details like this extremely useful in the main docs, so please do add there. -- ___ Python tracker ___

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Markus Holtermann added the comment: Thanks for your input, Berker. Updated as suggested. I still include the versionchanged annotation as I suspect more people to look at the docs than the entire changelog -- Added file:

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Berker Peksag added the comment: I think a Misc/NEWS entry is enough. We didn't use versionadded/versionchanged directives for similar changes in the past (mimetypes.types_map for example) Even if we decide to add an annotation it should be versionchanged, not versionadded (the API is not

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Changes by Markus Holtermann : Removed file: http://bugs.python.org/file44609/0001-Enable-WebSocket-URL-schemes-in-urllib.parse.urljoin.3.6.patch ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Changes by Markus Holtermann : Removed file: http://bugs.python.org/file44610/0001-Enable-WebSocket-URL-schemes-in-urllib.parse.urljoin.master.patch ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Changes by Yury Selivanov : -- nosy: -yselivanov ___ Python tracker ___ ___

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Markus Holtermann added the comment: Since the patch applies cleanly to the 3.5, 3.6 and master branch I only attached one updated version of it. -- Added file: http://bugs.python.org/file44612/0001-Enable-WebSocket-URL-schemes-in-urllib.parse.urljoin.patch

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Changes by Markus Holtermann : Removed file: http://bugs.python.org/file44608/0001-Enable-WebSocket-URL-schemes-in-urllib.parse.urljoin.3.5.patch ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Changes by Markus Holtermann : Added file: http://bugs.python.org/file44609/0001-Enable-WebSocket-URL-schemes-in-urllib.parse.urljoin.3.6.patch ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Changes by Markus Holtermann : Added file: http://bugs.python.org/file44610/0001-Enable-WebSocket-URL-schemes-in-urllib.parse.urljoin.master.patch ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Changes by Markus Holtermann : Added file: http://bugs.python.org/file44608/0001-Enable-WebSocket-URL-schemes-in-urllib.parse.urljoin.3.5.patch ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Markus Holtermann added the comment: As discussed with rbcollins during the KiwiPyCon sprints, I'll add patches for 3.5, 3.6 and master with docs mentioning the addition of `ws` and `wss` as of 3.5.3 -- nosy: +MarkusH ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Robert Collins added the comment: It is a bugfix, but we should document when it started working using the version added segment IMO. I think addding this to 3.6 now would be ok. -- nosy: +rbcollins ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Martin Panter added the comment: My view is that because the schemes are not in the documented list of supported schemes, this is a new feature, and any documentation update should include a “versionadded” or similar notice. -- components: +Library (Lib) stage: -> patch review

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Yury Selivanov added the comment: > The documentation should probably also be updated. It has a list of supported > schemes. I agree. Gergely, do you want to update your patch? > I imagine this would have to be taken as a new feature for 3.6+, rather than > a bug fix. Since urlparse can

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Martin Panter added the comment: The documentation should probably also be updated. It has a list of supported schemes. I imagine this would have to be taken as a new feature for 3.6+, rather than a bug fix. An alternative would be to enable joining for arbitrary schemes; see Issue 18828.

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Yury Selivanov added the comment: Gergely, the patch looks alright. Please sign the contributor agreement and we'll have it merged. -- nosy: +yselivanov ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Gergely Imreh added the comment: Just signed it, thanks! -- ___ Python tracker ___ ___ Python-bugs-list

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

New submission from Gergely Imreh: Handling the "ws" and "wss" schemes of the WebSocket protocol in urllib.parse.urlparse was discussed in a previous issue http://bugs.python.org/issue13244 Parsing them seems to work correctly: >>> urllib.parse.urlparse("wss://domain/endpoint")