[issue25941] Add 'How to Review a Patch' section to devguide

Ned Deily added the comment: The revised patch looks good to me (other than some trailing whitespace). Camilla, thanks for your contribution. If you haven't already, please sign a contributor form to cover this and future contributions as noted elsewhere in the Developer's Guide:

[issue25941] Add 'How to Review a Patch' section to devguide

Roundup Robot added the comment: New changeset 8b3f4473432e by Ned Deily in branch 'default': Issue #25941: Add "How To Review A Patch" section to the devguide. https://hg.python.org/devguide/rev/8b3f4473432e -- nosy: +python-dev ___ Python tracker

[issue25941] Add 'How to Review a Patch' section to devguide

Camilla Montonen added the comment: Thank you very much for your comments. I have cleaned up the previous patch and merged it with the Lifecycle of a Patch article. -- Added file: http://bugs.python.org/file42893/patchreview18May.patch ___ Python

[issue25941] Add 'How to Review a Patch' section to devguide

Ezio Melotti added the comment: +1 to the above message. There are also a couple of things that should be corrected: * bugtracker -> bug tracker * If the patch makes codechanges to C codebase -> If the patch affects any C file This could also be condensed a bit and merged with

[issue25941] Add 'How to Review a Patch' section to devguide

SilentGhost added the comment: Content of the article is in very reasonable shape, I have only couple of notes: 1. I don't think "production" is a good description of the python's repository workflow, so I'd suggest changing it to "repository". 2. Lack of links: instead of saying "check the

[issue25941] Add 'How to Review a Patch' section to devguide

Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___

[issue25941] Add 'How to Review a Patch' section to devguide

New submission from Camilla Montonen: This list is based on helpful tips and discussions received on the core-mentorship list and aims to help new beginners review patches in the bug tracker. The submitted patch is still in progress (the layout is a bit wonky and some details are still