[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

Berker Peksag added the comment: Thanks for the patch, Oren! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker __

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

Roundup Robot added the comment: New changeset a90f5e2b7160 by Berker Peksag in branch 'default': Issue #26130: Remove redundant variable 's' from Parser/parser.c https://hg.python.org/cpython/rev/a90f5e2b7160 -- nosy: +python-dev ___ Python tracker

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

Martin Panter added the comment: Sorry, the revision removing “register” is e7f6cef7a4cc. Not sure what happened there. -- ___ Python tracker ___ ___

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

Martin Panter added the comment: Yes it looks like this is code left over from removing the “register” keyword in revision 0530aadff696, Issue 18722. I quickly looked over the changes in that revision. I couldn’t find any more clear redundancies. I guess this patch is also applicable to 3.5.

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

Georg Brandl added the comment: Looks good to me. s was probably left over after a rewrite of the function. -- ___ Python tracker ___

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

Changes by SilentGhost : -- nosy: +benjamin.peterson, brett.cannon, georg.brandl, ncoghlan, yselivanov ___ Python tracker ___ ___ Pyth

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

New submission from Oren Milman: In Parser\parser.c in classify, the 'str' parameter is assigned into the local variable 's'. However, 'str' is not used anywhere else in the function, which makes 's' redundant. My proposal is to simply remove 's', and just use 'str' instead. The diff is attac